iOS bundle won't load about react-native-threads HOT 9 CLOSED

sorry I should have noted this is running on my iPad

from react-native-threads.

ps. I also verified that log message does indeed come from the ThreadManager.m:24

from react-native-threads.

Think I found the problem... In RCTBundleURLProvider.m:

- (NSURL *)jsBundleURLForBundleRoot:(NSString *)bundleRoot fallbackResource:(NSString *)resourceName
{
  resourceName = resourceName ?: @"main";
  NSString *packagerServerHost = [self packagerServerHost];
  if (!packagerServerHost) {
    return [[NSBundle mainBundle] URLForResource:resourceName withExtension:@"jsbundle"];
  } else {
    NSString *path = [NSString stringWithFormat:@"/%@.bundle", bundleRoot];
    // When we support only iOS 8 and above, use queryItems for a better API.
    NSString *query = [NSString stringWithFormat:@"platform=ios&dev=%@&minify=%@",
                       [self enableDev] ? @"true" : @"false",
                       [self enableMinification] ? @"true": @"false"];
    return [[self class] resourceURLForResourcePath:path packagerHost:packagerServerHost query:query];
  }
}

That bit of code will default to 'main.jsbundle' if there is no packagerServerHost. Not sure how this would ever work for release/production for the thread bundle?

(this is running "react-native": "0.49.1")

from react-native-threads.

oh wait... it just means the ThreadManager needs to pass the thread name along as the fallbackResource? Let me try that

from react-native-threads.

Ok getting somewhere..
1- needed to change the production script to --bundle-output ./ios/navigator.jsbundle
2- needed to edit the ThreadManager to pass the name of the thread to the fallbackResource

That now at least tries to load the correct bundle!

(but it now crashes with EXC_BAD_ACCESS on RCTImageLoader - no idea if that is related or not)

from react-native-threads.

That exception appears to be a red herring... refreshing did the trick.

I'll see if I can put together a PR for the ThreadManager

from react-native-threads.

@jliebrand Thanks for figuring all this out! You're right, the wrong file gets loaded in release mode 🙈 I'll go over your PR's now

from react-native-threads.

fixes are merged! thanks again for the help

from react-native-threads.

NP

from react-native-threads.