Comments (4)
You're right!
The issue is here:
https://github.com/joltup/react-native-threads/blob/master/android/src/main/java/com/reactlibrary/RNThreadModule.java#L182
We need up update the code to look for a .jsbundle
suffix rather than a .bundle
suffix
from react-native-threads.
@Traviskn I was planing on using background threads and sharing them across multiple screens/activities, this seems like good project being inspired from the earlier two which are no longer maintained.
Coning to the issue, is changing .bundle
to .jsbundle
only change needed for this to work?
If that is the case I would be haapy to raise a PR, otherwise too let me know how can I help here.
from react-native-threads.
yep that's the only change. I found that in our app we're just generating a .bundle
file for android and a .jsbundle
for iOS, but it would definitely be nice to make that more consistent
from react-native-threads.
This and the fact that the README states that the bundle should be generated with a .jsbundle
is probably confusing a lot of newcomers who wouldn't have the reflex to look at the logcat. Is there a reason it is still not fixed (backwards compatibility ?) or is it just noone did a PR.
If it is just a PR, I can make one.
from react-native-threads.
Related Issues (20)
- Unable to run react native app after ejecting from expo: error: constructor DevSettingsModule in class DevSettingsModule cannot be applied to given types; new DevSettingsModule(catalystApplicationContext, reactInstanceManager.getDevSupportManager())
- Main thread not receiving message HOT 2
- Multiple threads PROD environment
- Understanding HOT 1
- I don't think it works on 0.63 iOS HOT 3
- Error: Unable to resolve module `./worker.thread` from ``: HOT 5
- Invariant Violation: Native module cannot be null. IOS
- Worker thread has much slower performance HOT 4
- Using main bundle instead of thread bundle in iOS release mode (react-native 0.68.1) HOT 2
- Release mode build phase Xcode HOT 1
- [Delete me]
- Can't get message in thread.js on Android HOT 2
- Support new architecture
- Android App Crash
- ThreadManager.m uses `jsBundleURLForBundleRoot:fallbackResource`, which no longer exists in RN 68 HOT 2
- -
- Unable to connect to thread in ios release mode HOT 1
- [EXPO] Its possibility ability on expo?
- RN 69 is no longer auto-linking this module on iOS due to pod issues HOT 3
- Any guidance on using this library with version 0.70? HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-threads.