Android code replaces "/" with "_" in the thread path about react-native-threads HOT 10 CLOSED

Yeah, I got the following error when run gradlew assembleRelease:

FATAL EXCEPTION: mqt_native_modules
  Process: com.rsg.chess, PID: 6237
  java.lang.RuntimeException: java.util.concurrent.ExecutionException:
  Unable to load script from assets 'threads/._index.thread.bundle'.
  Make sure your bundle is packaged correctly or you're running a packager server.

Highlight: threads/._index.thread.bundle

Can you suggest how to fix it? @Traviskn

from react-native-threads.

Hi @radi-cho, can you show me your javascript code that is creating the thread? I suspect you may need to remove the leading ./ from your thread name. Apologies for the confusion, I probably need to update the example app and documentation

from react-native-threads.

The code that is replacing / with _ is in this file: https://github.com/joltup/react-native-threads/blob/master/android/src/main/java/com/reactlibrary/RNThreadModule.java#L61
I haven't gotten around to refactoring this code, but if removing this code that is changing the file path get's your app working we'd love to have a PR 😃

from react-native-threads.

Hello! Sorry about that but I made my own thread solutin because I had no time to wait your fix or response. However I like this package pretty much and it's good that you still maintain it. If you have not enough time for managing project like this another users, like me can stop using it and migrate to something else... So...

If you want you can grant write access to RSG Group and we will help with the maintenance 😃 😄 😀

Also please try to help to the other waiting people:

• #30
• #29

from react-native-threads.

react-native-threads is used in production every day in Jolt's applications. It works quite well for us and we maintain it primarily to meet the needs of our software. It is challenging to prioritize the time to field support questions here in Github, especially when not enough details are provided (such as a code sample replicating the error).

If users like yourself are able to find or create better solutions, that is great. The fact that you were able to re-implement your own solution within 10 days is pretty impressive! While we aren't wanting to give write access to developers outside of Jolt at this time, we are always open to pull requests.

from react-native-threads.

Great, thanks!

from react-native-threads.

Also can new developers join joltup?

from react-native-threads.

The Joltup Github organization at this time is for employees of Jolt, so getting hired would be the way to join

from react-native-threads.

Hello,

I had the same issue. For production the ./ will get translated to ._

Please update the example app and the docs. For now it is not possible to have the index.thread.bundle file in a folder. It has to be in the rootDirectory.

from react-native-threads.

The latest release fixes this issue, sorry it took me so long to get to it! example app and docs should work as expected, particularly android in release mode

from react-native-threads.