iOS Bundle Release about react-native-threads HOT 5 CLOSED

Hi @craigcoles, sorry you ran into this issue!

My understanding is that if your thread.js file lives in a different folder like App/Workers/MyWorker.thread.js, then you will need to re-create that same file structure in the ios folder. The path that you pass to the new Thread('some/path') is actually the native code filepath, relative to the ios folder in the root of your project. So in this case I believe you would need to open your project in xcode, right click on your root folder and select the "New Group" option to add an "App" folder, then select the "App" folder, right click, select the "New Group" option and create a "Workers" folder, then finally right click on the "Workers" folder and select the "add files to " option to add your worker js file to the native project.

For android you would create the matching folder structure in the android/app/src/main/assets/threads folder of your project.

Let me know if that makes sense or if it still doesn't work for you. Keeping thread files at the root level definitely keeps things simpler so that you don't need to add too many extra folders in your native ios and android directories. I'll make some time to add a bit more explanation of this to the README as well

from react-native-threads.

Thanks, I've merged your update to the docs! Let me know if you run into any more issues

from react-native-threads.

Problem solved 🎉

I moved the worker files from ./App/Workers/*.thread.js to the root ./*.thread.js and then rebuilt the bundles (after amending the locations in the commands also) and it now works as expected in release mode.

Before I close the issue, should the documentation be updated to say thats where they need to live? Or is it intended for the workers to live anywhere inside the project?

If your file is named differently or in a different location, you can update the documented commands accordingly.

[Ref]

from react-native-threads.

Hi @Traviskn, that makes complete sense! Would it be worthwhile updating the documentation to reflect this, as this wasn't massively clear for me. If so, I don't mind submitting a PR 👍

Update: I've opened a PR 👍

from react-native-threads.

Ref

So in this case I believe you would need to open your project in xcode, right click on your root folder and select the "New Group" option to add an "App" folder, then select the "App" folder, right click, select the "New Group" option and create a "Workers" folder, then finally right click on the "Workers" folder and select the "add files to " option to add your worker js file to the native project.

Without these steps, iOS build will not work. I had issue fetching the worker bundles, after adding the group in xcode, it started working.

from react-native-threads.