Comments (4)
Go package names shouldn't have -
in them, and it would be ideal if the package name matches the repo name so it's easier to pull in and reference. And if anything the word go
should be dropped to make it just dotenv
.
from godotenv.
I'm highly in favor of dotenv
.
Update
Since I didn't get any feedback on #116, I published the CLI as dotenv
on Webi: https://webinstall.dev/dotenv
cc/ @dexterp
from godotenv.
I won't be renaming this package as it's a language specific port of the initial ruby implementation named dotenv
(out of both respect to the original and also I used to have a local fork of the ruby library and it clased)
I also lived throug the great Logrus rename and it was such a high effort low reward shitshow on the client side I wouldn't do it to anyone else without an incredibly strong reasons.
from godotenv.
I understand your reasons behind the decision as its a massive breaking change.
For me personally as I mainly use the binary with make
it make sense to decouple the name from Go as I think its more conducive for adoption if the name wasn't prefixed with go
.·
Consider if certain tools were prefixed with the original language terraform
versus goterraform
, it doesn't make it any less useful but if I was a pure Python programmer or pure Ruby (I use both), I would scratch my head and think is it just for Go programmers only?
I also have a slightly selfish motivation. I'm writing a templating tool for project initialisation. When I get to it I want to include a dotenv/godotenv
binary to a standard template that includes a Makefile
. E.G.
# Makefile
DOTENV := godotenv -f $(HOME)/.env,.env
.PHONY: _build
# Run "make build" will run this target prefixed with $DOTENV·
_build:
gcc ...
# When "^${target}:" is called this catchall will look for an equvalent "^_${target}:" in the Makefile and execute it.
%:
@egrep -q '^_$@:' Makefile && $(DOTENV) $(MAKE) _$@
My thoughts turn to how to promote adoption and hence my thought process around naming.
Godotenv
can definetly still be added to homebrew
or an RPM/DEB created using goreleaser. Its the best compiled dotenv tool I've seen.
from godotenv.
Related Issues (20)
- godotenv is "complete" and not accepting feature requests HOT 1
- Expanding variable value
- expanding command line interface or linking to sister project
- How to set default value in yaml file
- dotenv does not report an error if file does not exist HOT 2
- Variables in dotenv file starting with capital letter when they shouldn't
- Bugs in parser around unquoted whitespace and newlines in v1.5.0 HOT 10
- `-` is not supported in the key from version 1.5 but is supported in 1.4. Can we please take a look here ? This is a very basic use case. HOT 2
- Variable in the form `VAR="${VAR:-default}"` does not parse correctly
- Getting double quotes in values in env file HOT 2
- .env: no such file or directory HOT 5
- Inline comments in .env breaks builds for linux amd64
- How tu use godotenv when testing implemented? HOT 2
- Failed to parse when yaml document delimiter is present
- LICENCE file is mispelled HOT 1
- There was a problem using the command "go install github.com/joho/godotenv/cmd/godotenv@latest" HOT 1
- inconsisting case handling across different OS HOT 1
- extractVarValue assumes a quote is escaped if a backslash precedes it, even if the backslash is escaped
- (possible) bug in parser right-trimming escaped quotes?
- Recursion in getStatementStart could be a loop
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from godotenv.