Autocompletion in different shells about marathon HOT 3 CLOSED

I'd love for Marathon to have auto completion support for all shells, I just started with zsh because that's what I use. I also went with the "generate a string in Swift" approach simply because I had a really hard time understanding how Zsh autocompletion worked, and once I got something working, I just pushed that 😅 There's definetly a lot of room for improvements, and I really welcome PRs in this area 👍

Since autocompletions are not "installed" by Marathon (for zsh it requires you to add the ~/.marathon/zsh folder), I don't think there's any harm generating that folder even if the user doesn't currently use zsh. Having to check for the current shell just adds complication, so I'd rather avoid that.

If we for example implement autocompletion for fish, we can simply put it in a fish folder next to the zsh one.

What do you think @cojoj?

from marathon.

I'd introduce one more level to this called autocompltions and inside have this distinction into different shells. Why? First of all, we don't have to pollute root directory with a couple of shell related directories. Secondly, if we decide to generate auto completions and reuse them in all shell generators - that'd be way cleaner approach.
I'll try to think about it more and come up with a PR presenting my vision 😉 So later we can decide in which direction we want to go.

from marathon.

Sure, sounds good! 👍 shouldn't be too many people using the zsh autocomplete yet either, since it hasn't been announced anywhere yet (except a note in the README), so I don't think changing the folder hierarchy is a big deal at this point.

from marathon.