Download succeeds without downloading file about jquery.filedownload HOT 5 CLOSED

Thanks for the heads up. Someone did a pull to 'cleanup' the IFRAME but this was an unintended consequence. Would you like to do a pull or should I integrate your fix manually?

from jquery.filedownload.

Thank you for the plugin! Feel free to integrate the fix manually - it's only two characters in one line. My only concern is that 500 ms is somewhat arbitrary. Could there still be cases where the iframe is removed before the file has been downloaded? that's why I was interested to hear if there were better solutions out there.

from jquery.filedownload.

I plugged in 1000ms, and it didn't seem to have any negative effect, but
it did solve our problem...
On Aug 7, 2013 12:13 PM, "Vassilis Liatsos" [email protected]
wrote:

Thank you for the plugin! Feel free to integrate the fix manually - it's
only two characters in one line. My only concern is that 500 ms is somewhat
arbitrary. Could there still be cases where the iframe is removed before
the file has been downloaded? that's why I was interested to hear if there
were better solutions out there.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/36#issuecomment-22262565
.

from jquery.filedownload.

Yeah... anytime you do a setTimeout > 0 its often less than ideal. Maybe I'll just take the cleanup out all-together. Someone did a pull on it once and though it was messy to leave the iframe around... Which is better an iframe stuck in the DOM or the thing not working?? I think I know the answer...

from jquery.filedownload.

Agreed - the best solution for now would be to remove the lines in cleanUp() that remove the iframe to get the plugin back to a working state. I do not particularly like the proliferation of iframes in the DOM but that's the lesser evil. Let me know when it's fixed and I can close the issue.

from jquery.filedownload.