Giter Club home page Giter Club logo

Comments (4)

JakeWharton avatar JakeWharton commented on June 18, 2024

Switching those two pieces of code will fix both problems.

When you call setSelectedNavigationItem() within the callback it does update the selected item successfully but the value gets overridden once the callback completes and the original selected item index replaces it.

from android-actionbar.

LorneLaliberte avatar LorneLaliberte commented on June 18, 2024

Yeah, the only downside would be that you couldn't query what the selection was before the onClick. You could easily track it yourself in your OnNavigationListener if you needed to, though.

from android-actionbar.

JakeWharton avatar JakeWharton commented on June 18, 2024

I agree that tracking the previous selection(s) is an exercise best left to the implementer since it is trivial and not likely something that would be used by a lot of users.

Good catch on finding this bug, though.

from android-actionbar.

johannilsson avatar johannilsson commented on June 18, 2024

Thank you, setting the selected index before executing the call back makes more sense.

from android-actionbar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.