Function "store_chain" crashes when parameters have the same name and index about bxa HOT 7 CLOSED

Yes, this is a good point. The code here is supposed to make columns compatible with xspec's mcmc functionality. I am not sure what xspec does in case of similar names. Does it attach the data group id or parameter id?

from bxa.

I neither know what XSPEC does for such cases, since I never used xspec's mcmc functionality.
As for BXA, one can get from xc.AllData.nGroups the total number of Data-Groups, which could be used to trigger a user warning if it's larger than one. However, BXA doesn't know from the transformations variable itself which parameter belongs to which Data-Group. Maybe, one could create an additional input variable for BXA, which supplies this information and which becomes mandatory if parameters from more than one data-group are used.

from bxa.

The following code snippet can be easily used to overcome this issue (I cannot get indentation correct here)
group_index=1
old_model=transformations[0]['model']
for t in transformations:
if t['model'] != old_model:
group_index+=1
old_model=t['model']
print(t['name'], t['index']+(group_index-1)*old_model.nParameters)

from bxa.

Thanks @ferrigno, I added your suggestion in the branch feature-multidatachain . Could you (or @alexkolo ) check out that branch and test if the fits files work in xspec?

from bxa.

Hi @JohannesBuchner . I have tested it in one case and it works. Thanks a lot for your prompt reaction.

from bxa.

Hi. I used it again and it works. Feele free to merge it on the master branch, if you wish.

from bxa.

done.

from bxa.