Giter Club home page Giter Club logo

Comments (1)

wainwrightmark avatar wainwrightmark commented on May 28, 2024

Hey. Just letting you know, that I've had a go at doing this with const generics and it's working great for me but my implementation probably isn't ergonomic enough for general use.

Basically I added a const PARAMS: usize everywhere and you set that to highest number of params you need for any of your sdf/fill combinations. I also added a ShaderParamUsage argument which controls which params are sent to the sdf and which to the fill. It does what I need it to do but is a bit of a pain to use and it probably isn't optimal performance wise so I'm definitely not suggesting this be merged or that this approach is even the right one, just wanted to share in case this was useful to anyone.

My code is here but

Just some notes:

  • I couldn't find a way to pass an array of f32 to the Vertex shader so I passed all the params individually. I'm not sure if this affects performance, but it does make passing an arbitrary subset of the params to each function much easier.
  • I had to write some unsafe code (empty impls of Pod and Zeroable for ShapeVertex since the derive macros don't with with const generics). I think this is fine but I'm not 100% sure.
  • I actually would like a way to pass in u32 params as well as f32. I'm getting away with it by using from_bits on the rust side and bitcast<u32> on the other but I have to be careful of NaNs and can't use the full range of possible values. It might actually be better to go the other way round and pass in everything as a u32.
  • I started passing in the position argument to the fill functions. It let me make some nice gradients

image

from bevy_smud.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.