Giter Club home page Giter Club logo

Comments (2)

joeblew99 avatar joeblew99 commented on June 3, 2024

i had to git clone the original code to get the make working..

git clone https://github.com/johanbrandhorst/protobuf.git

Still confused and would love to get to the bottom of this if you have any ideas.
It should not need this git clone, and should instead be using the vendor where the code lives already..

from grpcweb-example.

johanbrandhorst avatar johanbrandhorst commented on June 3, 2024

Hi! Somehow I wasn't getting notifications for this repo do I didn't realise an issue had been raised. Terribly sorry for the delayed reply.

You're absolutely right that the proto file dependency should be vendored, that just an oversight on my part. I'll take a look at this as soon as I have time, but I would also accept PRs. Might be worthwhile adding some CI to this repo as well for future changes.

from grpcweb-example.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.