Giter Club home page Giter Club logo

Comments (13)

dylanmei avatar dylanmei commented on July 30, 2024

I've not seen this myself. Please post any output you can when it happens again.

from packer-windows.

joefitzgerald avatar joefitzgerald commented on July 30, 2024

Is it possible that it's not a race condition, but rather an error installing OpenSSH (https://github.com/joefitzgerald/packer-windows/blob/master/scripts/openssh.bat#L4) which results in the files not existing?

It seems like we could capture this if we ensured OpenSSH installation produces a log?

from packer-windows.

sneal avatar sneal commented on July 30, 2024

It possible that it failed to download some of the times, but there's definitely more too it than that. I've seen it install OpenSSH fine, but then complain it cannot find the config files.

It becomes very easy to reproduce this when you replace the batch file with this powershell script. This is because it either runs faster since its a single powershell process or because powershell isn't waiting for the install command to finish. The commented out sleep is required in order to get the script to run successfully.

from packer-windows.

dylanmei avatar dylanmei commented on July 30, 2024

Thanks for sharing this, I'll check it out.

from packer-windows.

joefitzgerald avatar joefitzgerald commented on July 30, 2024

@sneal sounds like we should use your script, and increase the sleep to 15 seconds to be safe. Strange behavior, but anything's possible with a Nullsoft installer ;)

Want to make a pull request for that?

from packer-windows.

joefitzgerald avatar joefitzgerald commented on July 30, 2024

... And by pull request I mean... just commit the changes and push them in the develop branch ;) (By the way, we've switched to using git flow for this repo)...

from packer-windows.

sneal avatar sneal commented on July 30, 2024

sure, np

from packer-windows.

dylanmei avatar dylanmei commented on July 30, 2024

It works great for me running the installer like this

Start-Process "C:\Windows\Temp\openssh.exe" "/S /port=22 /privsep=1 /password=D@rj33l1ng" -NoNewWindow -Wait

@sneal, can you verify?

from packer-windows.

joefitzgerald avatar joefitzgerald commented on July 30, 2024

That makes sense - in general, you would want any installer that is launched to be run synchronously, by waiting for the PowerShell process to exit.

from packer-windows.

dylanmei avatar dylanmei commented on July 30, 2024

I've pushed 70ac237 which I can verify works pretty well here (win 2012 vmware/virtualbox).

I did convert the otherwise elegant...

$env:PATH > c:\windows\temp\PATH

to

Set-Content C:\Windows\Temp\PATH ([byte[]][char[]] $env:PATH) -Encoding Byte

...in order to prevent the automatic carriage-returns because Powershell is so darn helpful. PATH management in general has been the worst thing ever.

from packer-windows.

sneal avatar sneal commented on July 30, 2024

Nice, thanks Dylan!

On Saturday, December 7, 2013, Dylan Meissner wrote:

I've pushed 70ac23770ac2370ae9772c3068487d64183be35fb3e40cawhich I can verify works pretty well here (win 2012 vmware/virtualbox).

I did convert the otherwise elegant...

$env:PATH > c:\windows\temp\PATH

to

Set-Content C:\Windows\Temp\PATH ([byte[]][char[]] $env:PATH) -Encoding Byte

...in order to prevent the automatic carriage-returns because Powershell
is so darn helpful. PATH management in general has been the worst thing
ever.


Reply to this email directly or view it on GitHubhttps://github.com//issues/9#issuecomment-30064183
.

from packer-windows.

dylanmei avatar dylanmei commented on July 30, 2024

You bet. Thanks for the fine script. Let us know how it works out.

from packer-windows.

joefitzgerald avatar joefitzgerald commented on July 30, 2024

This has now been released in v1.3

from packer-windows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.