Giter Club home page Giter Club logo

Comments (4)

Ruslan avatar Ruslan commented on July 25, 2024 1

This is net/http feature to retry requests

https://github.com/ruby/ruby/blob/v2_7_6/lib/net/http.rb#L762

it can be fixed in HTTParty like this:

Benchmark.measure { HTTParty.get('http://httpstat.us/200?sleep=50000&q=', timeout: 10) rescue nil } 
# @real=20.28650915599428,

Benchmark.measure { HTTParty.get('http://httpstat.us/200?sleep=50000&q=', timeout: 10, max_retries: 0) rescue nil } 
# @real=10.168669935999787,

So if you have time-limited workflow with blocking http GET requests, it's better to set max_retries to 0 to avoid our current request timeout. This is really dangerous hidden feature in some cases (some vendors have non-idempotent GET requests)

from httparty.

jnunemaker avatar jnunemaker commented on July 25, 2024

Probably retrying either in httparty or in the level below automatically in net/http. Also read timeout can take longer because I think it's the time between bytes read so as long as a trickle of data is being read it can go longer.

from httparty.

jnunemaker avatar jnunemaker commented on July 25, 2024

Closing to keep tidy but if you can show that this is httparty and not net/http or something else I'm happy to try to fix or merge pull request.

from httparty.

carlosramone avatar carlosramone commented on July 25, 2024

I'm not sure if it's httparty or net/http, but whatever timeout is set is doubled. I will keep checking.

from httparty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.