Giter Club home page Giter Club logo

Comments (6)

headius avatar headius commented on July 3, 2024

We don't run the test suite, so I suppose there's no issue with us removing that.

from jffi.

headius avatar headius commented on July 3, 2024

@sjerman Actually, I'm confused why it will affect IP. This is a test file for a separate library, not included in binary forms of jffi or the native ffi library. As long as the license is clearly stated, there shouldn't be any issue just having it in the repository.

I can remove the test suite (after confirming it does not ever need to run) but it seems unnecessary.

from jffi.

sjerman avatar sjerman commented on July 3, 2024

The issue is that IP scanners pick up the license from the Jar. If the test
suite wasn't in the binary jar, that would work equally well.

Thanks
Steve

On Tue, Mar 8, 2016 at 8:05 AM Charles Oliver Nutter <
[email protected]> wrote:

@sjerman https://github.com/sjerman Actually, I'm confused why it will
affect IP. This is a test file for a separate library, not included in
binary forms of jffi or the native ffi library. As long as the license is
clearly stated, there shouldn't be any issue just having it in the
repository.

I can remove the test suite (after confirming it does not ever need to
run) but it seems unnecessary.


Reply to this email directly or view it on GitHub
#19 (comment).

from jffi.

headius avatar headius commented on July 3, 2024

If the test suite is getting included in the jar, that's definitely a bug.

from jffi.

sjerman avatar sjerman commented on July 3, 2024

It was a while since i looked at this... I think maybe it was being included in the source jar rather than the binary

from jffi.

headius avatar headius commented on July 3, 2024

Licenses for the project and contained files are clearly delimited, so I think this is a non-issue. If it becomes an issue for someone in the future, we can look at having these GPL sources fetched only for build or test.

from jffi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.