Giter Club home page Giter Club logo

Comments (4)

jmerriweather avatar jmerriweather commented on May 25, 2024

I primarily use this library against Active Directory and unfortunately it doesn't follow RFC 3062.

We could add in modify_password/3 and modify_password/4, we would just have to explain in the docs why there is change_password and modify_password and when to use one or the other.

from exldap.

Fnux avatar Fnux commented on May 25, 2024

Having both modify_password and change_password is seriously confusing. The ideal would be to add an ad_ prefix/suffix/parameter [0] to the original method, but will break compatibility with older releases...

[0] I think the AD case should be the "special case" since it doesn't follow the RFC.

from exldap.

Fnux avatar Fnux commented on May 25, 2024

Or some kind of server_type/is_active_directory parameter defaulting to the "AD way" to avoid breaking existing code, while keeping a somewhat sane API ?

from exldap.

jmerriweather avatar jmerriweather commented on May 25, 2024

Yeah I agree that it would be pretty confusing having both modify_password and change_password.
I like the server_type/is_active_directory idea.

server_type: :active_directory | :ldap

from exldap.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.