Giter Club home page Giter Club logo

Comments (6)

jmbuhr avatar jmbuhr commented on July 30, 2024 1

This is caused by #37 (comment).
I need to revisit this and see if now there is a way to get the correct ranges with offsets from injections applied.

If this is still not possible, maybe we can work around this by defining a set of surrounding characters that we remove from all captured text by default.

from otter.nvim.

jmbuhr avatar jmbuhr commented on July 30, 2024 1

I added the workaround for via #73 for now

from otter.nvim.

b0o avatar b0o commented on July 30, 2024

I just opened an issue for a very similar bug in conform.nvim, perhaps the root cause is related: stevearc/conform.nvim#229

from otter.nvim.

jmbuhr avatar jmbuhr commented on July 30, 2024

Looks like the same problem with the offset directive, indeed.

from otter.nvim.

b0o avatar b0o commented on July 30, 2024

Thanks for that! Just wanted to note that the PR did fix the diagnostics, but when running otter.ask_format(), the entire code block including

const foo = glsl`

and everything on the closing ` line is replaced.

from otter.nvim.

jmbuhr avatar jmbuhr commented on July 30, 2024

hm, interesting point. All that otter does is redicrect lsp formatting responses from the hidden buffer to the main buffer. i.e. if the lsp wants to change a line in the otter buffer it would change the line in the main buffer instead, but it should do so within the range of its language injection. For now the PR only changed the text content, not the range, so I'll have to modify that as well when a wrapping quote has been removed.

from otter.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.