Giter Club home page Giter Club logo

Comments (1)

jmathai avatar jmathai commented on May 16, 2024

Looks like there were missing tests on Media.get_class_by_file. I've added them and verified that the tests failed prior to my commit and passed after.

Before

..EEE
======================================================================
ERROR: elodie.tests.media.media_test.test_get_class_by_file_photo
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/tests/media/media_test.py", line 36, in test_get_class_by_file_photo
    media = Media.get_class_by_file(helper.get_file('plain.jpg'), [Photo, Video])
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/media/media.py", line 297, in get_class_by_file
    if(extension in Media.photo_extensions):
AttributeError: type object 'Media' has no attribute 'photo_extensions'

======================================================================
ERROR: elodie.tests.media.media_test.test_get_class_by_file_video
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/tests/media/media_test.py", line 41, in test_get_class_by_file_video
    media = Media.get_class_by_file(helper.get_file('video.mov'), [Photo, Video])
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/media/media.py", line 297, in get_class_by_file
    if(extension in Media.photo_extensions):
AttributeError: type object 'Media' has no attribute 'photo_extensions'

======================================================================
ERROR: elodie.tests.media.media_test.test_get_class_by_file_unsupported
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/tests/media/media_test.py", line 46, in test_get_class_by_file_unsupported
    media = Media.get_class_by_file(helper.get_file('text.txt'), [Photo, Video])
  File "/Users/jaisenmathai/dev/tools/elodie/elodie/media/media.py", line 297, in get_class_by_file
    if(extension in Media.photo_extensions):
AttributeError: type object 'Media' has no attribute 'photo_extensions'

----------------------------------------------------------------------
Ran 5 tests in 0.001s

FAILED (errors=3)

After

➜  elodie git:(gh-36-attribute-error) ✗ nosetests elodie/tests/media/media_test.py
.....
----------------------------------------------------------------------
Ran 5 tests in 0.001s

OK

from elodie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.