Giter Club home page Giter Club logo

Comments (3)

jlmakes avatar jlmakes commented on May 16, 2024

When I refresh the page, I see the initial reveals…

What’s odd, is that it seems everything reveals on first load (instead of when scrolled to). My suspicion is that by not having any declared height on any of the elements, the JavaScript views elements as "in viewport" before the HTTP requests complete.

"DOMContentLoaded fires when the DOM has been completely constructed. Certain elements may not have been completely defined or loaded, such as stylesheets, images, and iframes."

This is another issue that seems to stem from scrollReveal’s automatic instantiation upon the DOMContentLoaded event; the next release will address these types of issues.

This was addressed in #11

from scrollreveal.

mattrothenberg avatar mattrothenberg commented on May 16, 2024

Hey, @jlmakes!

Any news on this one? I'm experiencing some serious weirdness when using scrollReveal with a custom Wordpress theme (https://github.com/roots/sage).

I'm using Gulp to serve a preview of my website / build assets, and it seems that anytime I modify the original scrollReveal function invocation (e.g., passing a configuration object to the function below), I have to rebuild the entire Javascript pipeline via Gulp to get the new changes to work. Until I rebuild, I get a scrollReveal is not defined error in the console.

window.sr = new scrollReveal();

from scrollreveal.

jlmakes avatar jlmakes commented on May 16, 2024

This is a legacy issue. ScrollReveal no longer auto-instantiates, hopefully the theme author has maintained at least version 2 of ScrollReveal. I can’t offer any support for legacy issues (plus most of them have been fixed in later versions).

@mattrothenberg, but from what you’ve described, this sounds like an issue with the theme/gulp configuration… not a bug that can be fixed within ScrollReveal. I recommend opening an issue on the theme’s repository, as the theme author should be able to help you.

Edit: Also, there’s an existing issue for that theme which sounds related to what you’ve described.

from scrollreveal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.