souremaps arent being applied about speedscope HOT 5 OPEN

Hey! As far as I remember, there's no circumstance where source-maps are automatically applied. That said, speedscope lets you apply sourcemaps after-the-fact.

See #317

from speedscope.

speedscope lets you apply sourcemaps after-the-fact.

Thats cool! Unfortunately, dropping sourcemaps doesn't seem to have any effect on paths or symbols. Is there another way to load them that I can try?

from speedscope.

Could this be related to esm code? I tried generating my code as .js (from .mjs) but that didn't help. Any way to debug sourcemaps to see if they are finding anything to apply?

from speedscope.

I'm not sure offhand if this would have anything to do with esm!

If you want to debug, your best bet would be to step through the code here:

To get up and running locally, check out https://github.com/jlfwong/speedscope/blob/main/CONTRIBUTING.md

from speedscope.

Good call! It seems that the prof traces aren't having their filename/line/column populated. Not sure if this is the best way to do it, but the following patch fixes that:

diff --git a/src/lib/profile.ts b/src/lib/profile.ts
index 4e04742..13b189b 100644
--- a/src/lib/profile.ts
+++ b/src/lib/profile.ts
@@ -66,6 +66,15 @@ export class Frame extends HasWeights {

   private constructor(info: FrameInfo) {
     super()
+    if (!info.file && !info.line && !info.col) {
+      const matches = info.name.match(/(?:\/\/?)?([^:]+):(\d+):(\d+)/)
+      if (matches) {
+        info.file = matches[1]
+        info.line = parseInt(matches[2], 10)
+        info.col = parseInt(matches[3], 10)
+      }
+    }
+
     this.key = info.key
     this.name = info.name
     this.file = info.file

However, even with this patch, the frames aren't remapped to their proper sources.

from speedscope.