[Bug] AUTO_DISC_RIPPER_INTERVAL not being honored about docker-makemkv HOT 2 CLOSED

So I dug into the auto ripper code and I think I found the problem.

When you run the below command as pulled from the autoripper, the output is the same regardless of the container being on the internet or not. The difference is that when the container is on the Internet, the command returns(exits). When there is no internet, the command hangs even though the output is identical. Seems there is some required connectivity and indicates the problem is not in the autoripper but rather makemkvcon. It feels like it is trying to call home and can't.

I wonder if setting app_UpdateEnable = "0" in ~/.MakeMKV/settings.conf would prevent it from attempting to call home and hanging. Not sure how I would test this as there appears to be some caching.

/tmp # env HOME=/config LD_PRELOAD=/opt/makemkv/lib/libwrapper.so /opt/makemkv/bin/makemkvcon -r --cache=1 info disc:9999 MSG:1005,0,1,"MakeMKV v1.17.4 linux(x64-release) started","%1 started","MakeMKV v1.17.4 linux(x64-release)" DRV:0,2,999,28,"BD-ROM hp BD CMB UJ160 1.00 HN32 003368","SOMETITLEHERE","/dev/sr0" DRV:1,256,999,0,"","","" DRV:2,256,999,0,"","","" DRV:3,256,999,0,"","","" DRV:4,256,999,0,"","","" DRV:5,256,999,0,"","","" DRV:6,256,999,0,"","","" DRV:7,256,999,0,"","","" DRV:8,256,999,0,"","","" DRV:9,256,999,0,"","","" DRV:10,256,999,0,"","","" DRV:11,256,999,0,"","","" DRV:12,256,999,0,"","","" DRV:13,256,999,0,"","","" DRV:14,256,999,0,"","","" DRV:15,256,999,0,"","","" MSG:5010,0,0,"Failed to open disc","Failed to open disc" TCOUNT:0

Either way, it appears that this would only impact people trying to rip without an active internet connection. Hope the helps.

Feel free to either dig into this or close. Either way, I hope this helps anyone that has similar issues where their jlesage makemkv containers are not able to get to the internet.

Also thanks for an awesome project!

from docker-makemkv.

Reporting back after extended testing. Here is what I can confirm and two approaches to manually fix + 1 recommendation:

True issue - the Auto Disc Ripper is dependent on makemkvcon which periodically requires network connectivity to the mothership for updates. When there is no internet and it's time to check for updates this is a blocking action and prevents makemkvcon from returning and thereby breaks anything dependent on it.

User based solutions:

• Get your internet back online / allow the container to get to the internet.
• Set app_UpdateEnable = "0" in settings.conf in /config and restart the container.

Recommendation:

• Add an environmental variable that configures app_UpdateEnable when the container is stood up. This will help with headless installs and anyone that has crappy internet

Risks of implementing the recommendation:

• While MakeMKV is able to run without internet connectivity, the updating is there for a reason. Turing it off and pulling a new container when one is released may leave things in an outdated state. Recommend that if an environmental variable is created that it be defaulted to 1/On so that the user needs to make a conscious decision understanding the risks of turning off this setting.

Lastly - I wonder if this may account for other weirdness with the autodiscripper reported here. Wondering if turning it off may make some other problems go away. A blocking process can break tons of downstream things. When mine broke, it broke in stages and progressively got worse. Once I configured that setting everything came back.

from docker-makemkv.