Comments (6)
andersonfrailey
commented on July 23, 2024
1
I think mandating 1+ is fine. Especially since we're effectively moving to python 3.5+ only support by using f-strings (which I also fully support btw).
from pybaseball.
djcunningham0
commented on July 23, 2024
1
Looks good! Thanks for working on this, everyone!
from pybaseball.
schorrm
commented on July 23, 2024
@TAThor , @andersonfrailey -- what do you guys think about requiring this?
Quoting from the NumPy docs: "Changed in version 1.0.0: Now uses pandas.NA as the missing value rather than numpy.nan."
So I think we'd probably want to mandate version 1+?
from pybaseball.
schorrm
commented on July 23, 2024
3.6, but yeah. I think we can do this, and we can do the nullable int (="Int64").
I don't know about pandas.NA vs np.nan, but it just strikes me as simpler to mandate 1+ and not worry about this.
This is a nice-to-have, not necessarily top priority at the moment to go and implement, but if anyone wants to do this, I'd be delighted.
from pybaseball.
TheCleric
commented on July 23, 2024
This should now be resolved in #106
from pybaseball.
TheCleric
commented on July 23, 2024
@djcunningham0 can you confirm if this is resolved now?
from pybaseball.
Related Issues (20)
- MILB SCRAPE FROM NEW FANGRAPHS DATABASE HOT 1
- PyBaseball module not found in JupyterLab notebook HOT 5
- [feature] Scrape the yearly rookies page HOT 15
- list index out of range error for calling pitching_stats_range
- season_game_logs() from retrosheet.py returns error for all seasons HOT 1
- schedule_and_record doesn't work for any year/team combo HOT 4
- Pulling Park Factors from baseball savant
- pitching_stats(year) not working for some seasons HOT 2
- statcast_pitcher does not apply sanitize_input
- retrosheet.py returns an error for all functions HOT 1
- team_game_logs not pulling HOT 2
- Statcast Ball Counts > 3
- How to Get a Pitcher's Season-to-Date ERA heading into a specific date/game_pk?
- Minor League Statcast data
- Future Warnings in team_game_logs
- pitching_stats_range - occasionally not working
- Convert dtypes issue? HOT 2
- pitching_stats and batting_stats not returning all data HOT 3
- Imports HOT 6
- Missing cLI data interferes with streak calculation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pybaseball.