Giter Club home page Giter Club logo

Comments (12)

ccott235 avatar ccott235 commented on July 3, 2024 6

I am also experiencing the same issue.

from pybaseball.

DannyPhant8m avatar DannyPhant8m commented on July 3, 2024

Agreed, same issue arises for me. Any ideas on alternative way to receive player key_mlbam?

from pybaseball.

TobiasCortese avatar TobiasCortese commented on July 3, 2024

@DannyPhant8m - I'm pulling key_mlbam from the statcast (batter/pitcher) and baseball reference (mlbID) data

from pybaseball.

DannyPhant8m avatar DannyPhant8m commented on July 3, 2024

@DannyPhant8m - I'm pulling key_mlbam from the statcast (batter/pitcher) and baseball reference (mlbID) data

The statcast function provides both batter and pitcher key_mlbam, but the player_name column only tells you the pitcher. How do you know which batter correlates to the batter key_mlbam?

from pybaseball.

TobiasCortese avatar TobiasCortese commented on July 3, 2024

getting the same error with the chadwick_register. guessing it's all related.

from pybaseball import chadwick_register
--get the register data and save to disk
chadwick_data = chadwick_register(save=True)

from pybaseball.

moon0331 avatar moon0331 commented on July 3, 2024

https://github.com/chadwickbureau/register

It seems that reference file is seperated.
people.csv, referenced by chadwick_register(), was split into 16 files, people-[0-f].csv .

from pybaseball.

samlafell avatar samlafell commented on July 3, 2024

https://github.com/chadwickbureau/register

It seems that reference file is seperated. people.csv, referenced by chadwick_register(), was split into 16 files, people-[0-f].csv .

Exactly that. The PyBaseball team will need time to reflect changes in their function more than likely. Until then you'll need to write your own to reflect the change that's been made upstream from chadwickbureau.

from pybaseball.

TobiasCortese avatar TobiasCortese commented on July 3, 2024

@DannyPhant8m - I'm pulling key_mlbam from the statcast (batter/pitcher) and baseball reference (mlbID) data

The statcast function provides both batter and pitcher key_mlbam, but the player_name column only tells you the pitcher. How do you know which batter correlates to the batter key_mlbam?

@DannyPhant8m - I'm pulling key_mlbam from the statcast (batter/pitcher) and baseball reference (mlbID) data

The statcast function provides both batter and pitcher key_mlbam, but the player_name column only tells you the pitcher. How do you know which batter correlates to the batter key_mlbam?

@DannyPhant8m - I'm using bwar_pitch() to hack a join table

from pybaseball.

ccott235 avatar ccott235 commented on July 3, 2024

I've worked up a temporary fix that is working for me. Simply adjust the player_lookup.py file in the pybaseball folder as follows:

1. Change url on line 12 to:
image

2. Change lines 30-33 to:
image

from pybaseball.

tjburch avatar tjburch commented on July 3, 2024

Confirming this works after #309:

>>> data = playerid_reverse_lookup(player_ids, key_type='mlbam')
>>> data
  name_last name_first  key_mlbam key_retro  key_bbref  key_fangraphs  mlb_played_first  mlb_played_last
0     jeter      shawn     116541  jetes001  jetersh01        1006406            1992.0           1992.0
1     jeter      derek     116539  jeted001  jeterde01            826            1995.0           2014.0
2     jeter     johnny     116540  jetej101  jeterjo01        1006405            1969.0           1974.0

The forward lookup throws a bunch of warnings now but I'll open a new issue for that.

from pybaseball.

DannyPhant8m avatar DannyPhant8m commented on July 3, 2024

@tjburch, your above comment still does not work for me at the moment

from pybaseball.

tjburch avatar tjburch commented on July 3, 2024

There hasn't been a new release yet so it's not on PyPi. Install the library directly from git, not pip.

from pybaseball.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.