Giter Club home page Giter Club logo

Comments (8)

skellock avatar skellock commented on June 9, 2024 2

shipping now in 0.7, thx!

from reduxsauce.

franky47 avatar franky47 commented on June 9, 2024

In the mean time, I'm using the BYOAC feature:

const { Creators } = createActions({
  addTodos: (todos = []) => ({ type: 'ADD_TODOS', todos })
})

from reduxsauce.

skellock avatar skellock commented on June 9, 2024

The order will matter however object keys are not deterministic in some js environments.

We would have to do something like this to preserve the order.

addTodos: [{todos: []}]

from reduxsauce.

zhang-z avatar zhang-z commented on June 9, 2024

+1 to @franky47 's proposal:

createActions({
  addTodos: {
    todos: [], // default value
    anotherArg1: true,
    optionalArg2: null
  }
})

If the action is defined in this way, it will be invoked as:

Creators. addTodos({
  todos: [{title: 'hello'}],
  optionalArg2: 'xxx'
})

@skellock , if you agree with this approach, I can try to create a pull request

from reduxsauce.

skellock avatar skellock commented on June 9, 2024

I like this @zhang-z ya. Right now the interface is null or array. Adding object is compatible with the API.

Good idea.

from reduxsauce.

zhang-z avatar zhang-z commented on June 9, 2024

@skellock , I submitted a PR for this issue. Could you take a look?

from reduxsauce.

skellock avatar skellock commented on June 9, 2024

Thank you, it looks great. I haven’t had time just yet to try it out. Sorry.

from reduxsauce.

franky47 avatar franky47 commented on June 9, 2024

Thanks @zhang-z and @skellock !

from reduxsauce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.