Think about how module resolving should work about jk HOT 3 CLOSED

And it's not valid considering v8 will not resolve the same module specifier twice

Would you elaborate on why it's not valid?

There are certainly related problems introduced by how V8Worker2's LoadModule is implemented: specifically, it requires that the resolver callback calls LoadModule with the specifier exactly as given (otherwise it will regard it as not having loaded, afterward); but, it doesn't canonicalise them, meaning that has to be done in the resolver (otherwise the same module, referred to by different paths, will be re-initialised).

from jk.

There are two things intermixed in that comment:

• should import * from 'foo'; work when we mean import * from './foo'
• v8worker2 seems to be caching specifiers that have already been resolved, if I have two files in two different directories both doing import * from './foo, the way I read the code/comment is that the second ./foo will not try to be resolved and we'll use the first foo.js for the second file. Easier way is to test it I guess.

from jk.

We now have a good grasp on this and @squaremo just fixed the relative import with identical specifiers issue. Let's close it! More precise issues should be opened when needed.

from jk.