Giter Club home page Giter Club logo

Comments (6)

jjmccollum avatar jjmccollum commented on August 24, 2024 1

@rbturnbull I've pushed a first pass of revisions to the paper on the paper-revision branch. I don't remember where we accessed the generated PDF on GitHub, but if you do, any feedback or further changes from you would be appreciated! I added several citations, though some of the sources (like those from Andrews University Seminary Studies and the Journal of Machine Learning Research) do not appear to have DOIs.

If everything looks good, I'll make a pull request and close this issue.

from teiphy.

rbturnbull avatar rbturnbull commented on August 24, 2024

Hi @jjmccollum - you can render the paper using the ./paper.sh script in the base of the repo if you have docker running. Otherwise the CI pipeline for the docs renders and deploys the paper to https://jjmccollum.github.io/teiphy/joss-draft.pdf for every push to the main branch. Can either of those options work for you?

from teiphy.

jjmccollum avatar jjmccollum commented on August 24, 2024

Sure! I'll do a pull request to merge paper-revision with main so we can check the main paper on the main branch, but I'll leave this issue open until I have your feedback.

from teiphy.

jjmccollum avatar jjmccollum commented on August 24, 2024

@rbturnbull Sorry for the additional changes on my end; once I could see the PDF, I made some further commits to fix wording and formatting problems I noticed in it. I'm done with edits, so feel free to take a look when you get a chance!

from teiphy.

rbturnbull avatar rbturnbull commented on August 24, 2024

Hi @jjmccollum - the revisions look great. I think it might be good to list the other export formats in the summary. I think it's a key feature that it can export to PHYLIP, FASTA etc.

from teiphy.

jjmccollum avatar jjmccollum commented on August 24, 2024

@rbturnbull Thanks! I've made that update, and you should be able to see it in the paper now. I'll close this issue and have editorialbot validate the paper again.

from teiphy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.