XMPP contact in multiple groups about jitsi HOT 51 OPEN

@mpicher Will you help with testing if I provide build for you?

from jitsi.

We have just started using jitsi and this is a big nuisance for us, as it makes groups essentially useless!
in the scenario where you need to message any online user in a particular team, you cannot do this, because most our users are members of more than one group (team).
Please, please can someone fix this ASAP.

from jitsi.

I see that a new version came out today, but in the changelog there is still no fix for this issue :-(
please, please could someone take a look.
Thank you.

from jitsi.

This would be a big help...

from jitsi.

Still happening

from jitsi.

@djadk84 the same question.

from jitsi.

@ibauersachs does it make a sence to add something like version to contact list cache? I mean contactlist.xml. Currently when there is no any option for checking cache version Jitsi doesn't show contact in multiple groups untill I don't remove contactlist.xml or remove/add account.

from jitsi.

I'm unsure why this is needed, but I don't care much about a version attribute if it's necessary.

from jitsi.

@GNUDimarik - yes!

from jitsi.

@mpicher here is the build: https://www.dropbox.com/s/yc8f2v0n92wv25d/jitsi-2.11.0-x86.exe?dl=0
The only thing which I miss: you need to remove and add xmpp account again. Investigating now what I need to do for update contact list cache automatically.
Please test roster functionality for regressions such as add/remove contacts etc and let me know if I broke something.

from jitsi.

@mpicher pls ignore that build. I was very wrong. I understood right way for implementation. Commints above are wrong.

from jitsi.

from jitsi.

@mpicher thanks!!!
Here is the build. We are testing it at the moment. Please help us.
https://www.dropbox.com/s/lyjb40jtynzmjzx/setup.msi?dl=0
Sorry for a big package. I broke building evnironment ...
Looking forward for your feedback, Also if you use openfire please me kow how you configure the groups.

from jitsi.

I noticed when I adding user to second or third groups server not always send me update info about all members .... But may be it's my network.
@mpicher please share the logs if you have some issues.
Thanks for your help!!!

from jitsi.

from jitsi.

There is windows build. Will ask friend to make Mac one.
Do you have windows. Did you try the build?

from jitsi.

@AlexKuznetsoff pls make mac build

from jitsi.

from jitsi.

@mpicher my QA team found there some issues. But you can use it I think if you use only standard functionality .... I hope you will not face with them. I'll fix them soon and then provide you new binary.
And only when QA tells me all right I'll make pull request.
Thanks for your help!

from jitsi.

from jitsi.

@GNUDimarik Taking a preliminary look at your code, I've noticed that there now might be multiple ContactJabberImpl with the same ID. This shouldn't be the case, a contact is unique, i.e. findContactById must never return a list. What is wrong with our current implementation is the assumption that a contact is only ever in a single group, i.e. getParentContactGroup must return a list instead of a single group (rename it to getParentContactGroups).

This probably requires changes to all implemented protocols, however, it's fine to simply return the only group of a contact for non-XMPP protocols.

from jitsi.

@ibauersachs as I told that's commits are wrong. Now contact is unique but multiple groups. Will commit new code soon .... want to fix some test cases from QA before.
Thanks for review!!!!!

from jitsi.

Coming soon ...

from jitsi.

from jitsi.

@mpicher I think it's 70% complete just last two weeks I had no chance to work on this. Will continue soon.
I work on this in my free time.

from jitsi.

@ibauersachs I have a lot of changes ... is this good for review to make multiple commits?

from jitsi.

It's good to have multiple commits so you can track your changes. It doesn't really matter for reviewing though as I'm only looking at the complete diff, not individual commits.

from jitsi.

FInally I have time to back to this. Last time I fixed all issues except presence handling.
@ibauersachs is there any QA in community?

from jitsi.

Damencho might give some advice there in the community forum.
There were some rather big changes in the Smack4-2 branch, which basically has become master. Your work is based on that, right?

from jitsi.

No. I used master. But it's no problem I can switch to new smak. Here is my old question about that:
https://community.jitsi.org/t/jitsi-desktop-does-it-make-a-sence-to-fix-bugs-in-branch-smak-4-2-instead-of-master/14882/4

from jitsi.

@damencho shall we merge smack4-2 back to master? I don't think anybody cares about a 2.12 release anymore anyway.

from jitsi.

We can. And this will update to java8 and currently builds are disabled cause we don't have windows certs.

from jitsi.

Wdyt?

from jitsi.

Yeah, just merge. Ubuntu 18.04 LTS has Java 11 and Debian Buster with Java 11 is in freeze.

Can you get a Windows Cert via 8x8?

from jitsi.

Will give you an answer today.

from jitsi.

It would be great to merge new smack to master since it automatically should fix some opened issues. Afair somewhere I saw some requests for stream control or something similar. Also it opens door to easy implementation of OMEMO etc

from jitsi.

@ibauersachs I understand it's unrelated topic but I working on porting directshow wrapper for gstreamer now: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/12#note_151674
What do you think about switching libjitsi to gstreamer in future? I think in this case we able to use the same native code for all platforms and also I'd implement requested feature about calls recording after this.
Please let me know your opinion

from jitsi.

libjitsi is already flexible enough to add another audio/video backend. If you want to go for that, feel free. But I'd rather concentrate on stabilizing or updating the existing backends, e.g. updating PortAudio, or creating a build pipeline (e.g. on Azure) that builds the entire libjitsi + libjitsi-(l)gpl from source for all platforms.

Regarding OMEMO, this would need to be a standalone plugin, not affiliated with the Jitsi project itself, because of the licensing issues.

But AFAIK even Smack 4.2 is now rather outdated. An update to 4.3.x shouldn't be as painful anymore as it was for 4.2 though. @damencho if someone (i.e. currently not me) would do that, any objections for Videobridge&Friends?

from jitsi.

I have experience with porting Jitsi fork to smack 4.4.1-alpha (at that moment). Previously I ported it to 4.3 and switching from 4.3 to 4.4.1 required updating jxmpp and something else.

from jitsi.

@ibauersachs

But AFAIK even Smack 4.2 is now rather outdated. An update to 4.3.x shouldn't be as painful anymore as it was for 4.2 though. @damencho if someone (i.e. currently not me) would do that, any objections for Videobridge&Friends?

We do not mind, except for some time(for 3 more months), we may continue using 4.2 branch to no add some unknown risks and if we want some fixes we will need to push them on both places. We had extracted the custom smack extensions in a separate project, I hope those do not need update moving to 4.3, as we will need to also branch those.

from jitsi.

@ibauersachs after your suggestion about stabilization of current stuff instead of implementation new one I checked one thing in current directshow code. It seems there are some memory leaks ...
I'll refactored code from there and used in another project so I have great working and good tested code.
Will integrate it to libjitsi instead of current when I have time

from jitsi.

@damencho when do you think smack-4 should be merged to current master?

from jitsi.

@ibauersachs @damencho once I have time on this issue again I'll switch development to branch smack 4-2 then and after changes will be able to merged to master with that branch.
Please let me know: does it make a sence to fix another contact list related issues in master?

from jitsi.

No, it doesn't. Take smack4-2 as the base branch for all improvements.

from jitsi.

@ibauersachs
What branch use jenkins for weekly/night builds? I lost changes for making installer buildable locally (my old SSD is dead) so would be great if usesrs able to get nightly/weekly build from jenkins for testing.

from jitsi.

Master, but all builds are currently disabled.

from jitsi.

@ibauersachs
So is there any way for users to get release with latest fixes?
Is this possible to switch jenkins to smack4-2 or merge smack4-2 to master?

from jitsi.

We will merge it next week.
But about the builds, I'm not sure when we will be able to take windows certificates for signing the app, maybe at some point after May 15. I can enable the builds and just disable the windows one for now.

from jitsi.

@damencho
Ok. Great! I'll wait for next week then and start work when master is based on smack4-2.
Please do since some users use mac and linux I think they should not be blocked cause windows issue

from jitsi.

@GNUDimarik: You can look my tickets about XMPP ;)

• XMPP protocol (RFCs) support
• XEPs support
• SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) support
• Smack update
• ...

from jitsi.

Not really. I working on Jitsi for free (in general) and only when I have time.
If I do something in rush I have a lot of comments in review ...
If someone hire me for working on Jitsi then I fix provided by customer issues list.
About your list:

Smack update afair @damencho updated smack to 4.x.x

from jitsi.