Cannot use `rel_loss_cls = dict(use_sigmoid=True)` about openpsg HOT 7 CLOSED

That seems weird to me. use_sigmoid should not affect the out channels. Did you change other stuff?

from openpsg.

Sorry for the late reply.

1. I am quite sure I changed nothing from the original code;
2. This snippets suggests that use_sigmoid will affect the value of *_out_channels.

   OpenPSG/openpsg/models/relation_heads/psgtr_head.py

   Lines 187 to 200 in 23f9c89

   	if self.obj_loss_cls.use_sigmoid:
   	self.obj_cls_out_channels = num_classes
   	else:
   	self.obj_cls_out_channels = num_classes + 1
   	if self.sub_loss_cls.use_sigmoid:
   	self.sub_cls_out_channels = num_classes
   	else:
   	self.sub_cls_out_channels = num_classes + 1
   	if rel_loss_cls['use_sigmoid']:
   	self.rel_cls_out_channels = num_relations
   	else:
   	self.rel_cls_out_channels = num_relations + 1

from openpsg.

I guess a potential bug is that class labels in gt_rel starts from 1 rather than 0, therefore the reduction of cls_out_channels could lead to IndexErrors (as it doesn't happen on subject and object, but only relation). However I am not sure about the associated codes with this special setting, much appreciated if you could point them out.

from openpsg.

I am not quite sure too. The code is written by mmdet.
To avoid this, what I would suggest is to write a loss function by your own.

from openpsg.

Thanks. I'll try to figure it out by myself.

from openpsg.

@GSeanCDAT You could also comment here.

from openpsg.

@ShunchiZhang Hi there,
I think the possible solution might be to turn the gt_rels into one-hot before calculating the loss. (make sure you set the first element of one-hot as the background class).

from openpsg.