Streaming breaks for HTTP client when fields are not str, int, or float about jina HOT 10 CLOSED

Note that removing theMyDocument.other_doc field makes the example work again.

from jina.

Hey @NarekA,

Thanks for reporting the issue. If you have a fix proposal we would be glad to get the contribution

from jina.

Of these solutions, do any of them make more sense to you?

1. Use http get with a body. See this link

   Sending a body with a GET request has an undefined behavior in the specifications, nevertheless, it is supported by FastAPI, only for very complex/extreme use cases.

I like this one, but it looks like fastAPI might not include the fields in the docs.

2. Use a different http method

The best solution if it's possible

3. Serialize/deserialize the fields before IO.

Might make more sense to serialize the whole object as one param rather than try serializing individual params

Any reason we can't use http post?

from jina.

@JoanFM Any reason this is using get?

from jina.

@alaeddine-13 may have better insights as per this

from jina.

@NarekA Actually the convention when implementing SSE in HTTP is to use GET methods instead of POST. The drawback of using GET is having to serialize the document as query string parameters. However, developers can use clients that follow the convention when using SSE. For instance, mozilla's js client EventSource implements SSE client using GET method.
I suggest flattening your document schema in case
@JoanFM I remember wanting to include a duplicate POST method for such a case, such that, if you want to follow convention -> use GET endpoint and if you want nested schemas -> use POST endpoint

from jina.

@alaeddine-13 we are currently working around this by "flattening" the document, but that effectively removes any benefits of the upgrade to Docarray V2. It also means that the framework doesn't support all docarray inputs (for http at least) and that should be communicated. Would it be hard to create a second endpoint? I could look into this one if it helps.

from jina.

We are definitely going to look into solving this issue. Yoy are right, in the Documentation is not stated

from jina.

@JoanFM @alaeddine-13 I drafted a PR that seems to fix this issue for me: https://github.com/jina-ai/jina/pull/6091/files

from jina.

It seems nice @NarekA,

I added some comments to the PR

from jina.