Is an 'auto-crop' feature scheduled? about jimp HOT 9 CLOSED

jimp is so lowe level and so straightforward to use that a feature like that, so specific, would not add much value and instead add complexity.

You layed out the algorithm, now it's a matter of implementing it 😄

from jimp.

Yup! I did never read throughtfully jimp docs, now I see there is a getPixelColor(x, y) method... So yes, I'll try to implement an autocrop() method myself... Or should I directly use bitmap data, to improve performance?

from jimp.

@marcolino, I'm happy to include in an auto-crop method. If you implement it and make a pull request, I'll happily pull it in. Alternatively, if you can write a simple method using the API and post it here, I'll add it to the code base.

from jimp.

Hi!
I'm trying to git push origin autocrop-branch, to easily create a PR, but am I supposed to know repository authentication, to push a branch?

from jimp.

1. Create a fork by clicking the link in the top right here: https://github.com/oliver-moran/jimp
2. Check that out, make your modifications and save your changes to the fork.
3. Then go here and create a new pull request: https://github.com/oliver-moran/jimp/pulls

from jimp.

Yes... I forgot to fork, but did clone directly from your repo... :-(
Sorry, it's a long time from my last PR... :-)
Please let me now what you think about the autocrop feature...

from jimp.

Merged the pull request here: #71

Thanks!

from jimp.

Sorry, last question: I have already some minor changes to autocrop... Should I create a new PR, or what?

from jimp.

Sure thing, just create a new pull request from the fork you have.

I think you might even be able to do it in the same thread: #71

from jimp.