Comments (10)
A status update: I had started working on using ASM to remap all Craftbukkit usages, only to find out that now Paper has unbent a little more on their stance and now remaps plugins. Now all that needs to be done to is load the correct internals for the unversioned package, which I did a couple days ago.
I also noticed that player data is not saving correctly when doing offline edits (I swear I checked that and it was working on Spigot before, but rolling back to the previous Spigot build yields the same problem), so that is the current release blocker.
from openinv.
For anyone who is running Spigot and wants to update OI in the meantime, builds can be downloaded from runs of the CI action: https://github.com/Jikoo/OpenInv/actions/workflows/ci.yml?query=branch%3Amaster
from openinv.
How ro download
from openinv.
You cannot currently download a fully functional build because of the bug I mentioned in my previous post. You can download one of the buggy builds from the corresponding actions run, the dist artifact.
from openinv.
PaperMC currently automatically remaps spigot-mapped jars to paper-mapped jars before a plugin loads automatically. The only thing that it doesn't work for is reflection. If I'm not mistaken, OpenInv uses modules and not reflection to use NMS internals. Wouldn't it just work on its own?
from openinv.
OI uses reflection to load the correct corresponding classes. 170ebaa will update this to handle Paper's changes.
from openinv.
I see, though I was mainly referring to the part where you mention the need to use ASM to rewrite classes at runtime on Paper on your own.
from openinv.
Guess I should update OP.
from openinv.
Ah, sorry for not reading carefully. My bad.
from openinv.
Finally found the problem after going in circles for hours, one little change. PlayerDataStorage#load(Player)
now also tries to load the data into the player. The most painful part about it is that's the first place I had looked for changes, and somehow overlooked it.
from openinv.
Related Issues (20)
- OpenInv in certain worlds HOT 1
- 1.20 HOT 1
- /searchinv HOT 1
- Dupe error HOT 1
- Folia support for OpenInv? HOT 1
- Inventory Modify Event HOT 2
- Update to 1.20.2 HOT 2
- Exception on server start HOT 2
- Opening an offline player's inventory will reset the player's world when using Paper HOT 10
- using openinv duplicates peoples' inventories HOT 1
- Update to 1.20.4 HOT 2
- Inventory getting scrambled? HOT 5
- Version update to 1.20.4 HOT 1
- Inventory Loss when editing inventory in another non-main world HOT 27
- Random Bad Interaction with Brewery HOT 4
- Searchcontainer doesn't work outside render distance HOT 1
- Prepare for Paper's removal of versioned packages HOT 1
- Items are duplicated when moving them using OpenInv HOT 1
- [Feature Request] Add cursor item support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openinv.