Table.page handle incorrect page number about django-tables2 HOT 5 CLOSED

I hadn't thought about this before, but I totally agree. I think Table.page should be rewritten to not handle the exception, that code should be moved to SingleTableMixin. However as the code should be customisable.

I feel like perhaps pagination.page(number) should actually be executed in Table.paginate, so that EmptyPage and PageNotAnInteger are raised those that call, rather than being delayed until Table.page.

One possible pattern would be to just require get_table to be implemented in subclasses:

class Example(tables.Table):
    # ...

    def get_table(self):
        try:
            return super(Example, self).get_table()
        except PageNotAnInteger:
            # ...
        except EmptyPage:
            # ...

I'm not sure how the Meta flag you option would allow arbitrary handling of pagination exceptions (and really the general case here is table configuration errors)

from django-tables2.

Yes, I agree moving pagination.page(n) to Table.paginate would actually work quiet well. The pattern you mentioned would be even better (one place to implement the handling vs. dozens of (nearly) equal code parts).

With the Meta flag I just thought about a way to switch between the current and possible new behavior for compatibility reasons. So the "new" behavior would be opt-in for a while. There might be people checking for the Http404-Exception atm.

from django-tables2.

Any thoughts on the Meta variable name? Alternatively it could be passed to Table.paginate(), and set as a default in SimpleTableMixin.

from django-tables2.

Something along the lines of "page_out_of_bounds_action"(=404/page1/...) ? But thats terribly long....
I'm also thinking about a way to do things like an HttpRedirect in that case.. so maybe re-raising should be also possible?

from django-tables2.

RequestConfig now handles pagination errors silently. This happens when silent=True is included in its paginate argument, e.g. RequestConfig(..., paginate={"silent": True}) (or when it's not specified). It handles exceptions as follows:

• EmptyPage -> render last page
• PageNotAnInteger -> render first page

from django-tables2.