Comments (4)
jkinkead
commented on July 28, 2024
I have a fix that appears to work, but fails during unit test validation; I can't get make_protos.sh to work correctly. If you have any pointers, I'm happy to get this working and submit a patch!
from protoreflect.
jhump
commented on July 28, 2024
@jkinkead, sorry you couldn't get make_protos.sh to work. Any hints on what part of the script was failing? If you can make some changes to get it to work in your environment, I'll take a patch.
I just merged a small change that appears to address it. Let me know if it looks anything like your fix and re-open this issue if it doesn't address it for you.
from protoreflect.
jkinkead
commented on July 28, 2024
Awesome, I confirmed that fix works. Your solution is cleaner than mine was, as well. :)
make_protos.sh was giving me errors because it couldn't find google/protobuf/descriptor.proto:
google/protobuf/descriptor.proto: File not found.
desc_test_options.proto: Import "google/protobuf/descriptor.proto" was not found or had errors.
desc_test_options.proto:9:8: "google.protobuf.MessageOptions" is not defined.
desc_test_options.proto:13:8: "google.protobuf.FieldOptions" is not defined.
desc_test_options.proto: "google.protobuf.FieldOptions" is not defined.
desc_test_options.proto:18:8: "google.protobuf.EnumOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumOptions" is not defined.
desc_test_options.proto:26:8: "google.protobuf.EnumValueOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumValueOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumValueOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumValueOptions" is not defined.
desc_test_options.proto: "google.protobuf.EnumValueOptions" is not defined.
desc_test_options.proto:34:8: "google.protobuf.ServiceOptions" is not defined.
desc_test_options.proto: "google.protobuf.ServiceOptions" is not defined.
desc_test_options.proto:39:8: "google.protobuf.MethodOptions" is not defined.
desc_test_options.proto: "google.protobuf.MethodOptions" is not defined.
It's possible that I haven't installed protoc correctly (IIRC I used homebrew), or I'm missing a key dependency / path item.
from protoreflect.
jhump
commented on July 28, 2024
protoc installations should include these proto files. Typically, they are installed alongside the protoc binary (like in an include folder that is a sibling of protoc or, if protoc is in a bin folder, the include folder is sibling of that).
I have a custom protoc install at the moment, built from source, and it works. You might try that (clone the protobuf repo and build the binary -- which will end up in the src directory of the repo).
from protoreflect.
Related Issues (20)
- EnumBuilder panics if it contains EnumValue with explicitly set Number HOT 1
- might not be bug: false duplication report due to use of relative path instead of absolute path HOT 6
- SIGSEGV: panic: runtime error: invalid memory address or nil pointer dereference in v1.15.2 HOT 8
- Protoreflect doesn't fall back to to v1alpha when a gRPC unimplemented response is returned HOT 1
- String escaping in protoprint is wrong HOT 1
- First enum value must be 0 in proto3 [protoprint] HOT 2
- missing `{}` after printing option HOT 5
- Upgrade protocompile to v0.7.0 HOT 3
- go build error HOT 3
- Regression upgrading from v1.14.1 to v1.15.4: extensions are resolved recursively instead of non-recursively HOT 1
- Regression upgrading from v1.14.1 to v1.15.4: absolute paths no longer accepted by parser.ParseFilesButDoNotLink HOT 3
- Regression upgrading from v1.14.1 to v1.15.4: new mustBeSource constraint/check HOT 5
- Stub structure and Methods will relay on protobuf API V2 HOT 15
- Fail to compile proto file HOT 2
- Tests broken with google.golang.org/protobuf v1.33.0
- If there are messages nested in the proto file, the numbers will be recognised as strings HOT 2
- invalid memory address or nil pointer dereference HOT 5
- will return Symbol not found when the proto file has enum definition HOT 1
- Is there a way to UseProtoNames? HOT 2
- desc/builder: feature request: auto-de-duplicate builders and already-built descriptors in transitive graph HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protoreflect.