Giter Club home page Giter Club logo

Comments (1)

jhump avatar jhump commented on July 28, 2024

Leading dots are the way that a symbol is unambiguously marked as fully-qualified in proto source code, since the proto languages allows you to refer to types in a less-than-fully qualified manner. The value returned by this function includes all of its enclosing namespaces, including the package, so it is fully qualified.

I don't agree that this should emit the leading dot, and there is plenty of prior art in the actual protobuf runtime with which this is consistent (such as this and this).

Also worth pointing out that this change would not be compatible with existing code that expects current implementation, and its value is quite unclear. Unless you are writing a name resolver that supports a namespace context and unqualified names, it's not necessary (or useful?) to include the leading dot. You know it's fully-qualified because the Go doc says so.

This is also documented in FieldDecriptorProto.

That documentation is specifically for value of the type_name field of FieldDescriptorProto.

Could you be more specific about why you think this is valuable or necessary?

from protoreflect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.