Giter Club home page Giter Club logo

Comments (15)

jhilden avatar jhilden commented on September 10, 2024

Hey @eprothro,
yes this = dependency is intentional to make sure that the 2 gems work correctly together. You should only put jquery-ui-sass-rails in your Gemfile, since that will already pull in jquery-ui-rails in the correct version.

I tried to adjust the README accordingly: 4ec306b Please let me know (or make a PR) if I can make it even clearer.

from jquery-ui-sass-rails.

eprothro avatar eprothro commented on September 10, 2024

Thanks very much for the reply and the timely doc update, very helpful and
clear!

Only out of curiosity, would a ~> or an explicit >= and < make more
sense to allow for a little more flexibility to allow users access to
bugfixes or minor updates in the jquery-ui-rails dependency without
having to wait for you to update to a new version?

Thanks again!

-Evan Prothro
Sent from my mobile

On Aug 14, 2013, at 2:23 AM, Jakob Hilden [email protected] wrote:

Hey @eprothro https://github.com/eprothro,
yes this = dependency is intentional to make sure that the 2 gems work
correctly together. You should only put jquery-ui-sass-rails in your
Gemfile, since that will already pull in jquery-ui-rails in the correct
version.

I tried to adjust the README accordingly:
4ec306bhttps://github.com/jhilden/jquery-ui-sass-rails/commit/4ec306be7c7762f3a20ca3e3d2743bda29c888c8Please
let me know (or make a PR) if I can make it even clearer.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/4#issuecomment-22618979
.

from jquery-ui-sass-rails.

mattsjohnston avatar mattsjohnston commented on September 10, 2024

I'm having a dependency conflict between this and Activeadmin, which requires jquery-ui-rails 4.1.0. I'd second the request to get a more flexible dependency if possible.

from jquery-ui-sass-rails.

aaronstarkey avatar aaronstarkey commented on September 10, 2024

+1
i'm also having a dependency conflict with rails_admin.

from jquery-ui-sass-rails.

eprothro avatar eprothro commented on September 10, 2024

@jhilden if you reconsider, I'm happy to submit a PR.

Personally, if you're very concerned about version alignment, I think a post-bundle or on-init warning might be more appropriate than the explicit version constraint.

from jquery-ui-sass-rails.

jhilden avatar jhilden commented on September 10, 2024

does that already help? 13eabf0

can you describe the exact depency conflict (with all version numbers)

I would be very open to a PR, how would you solve the issue?

from jquery-ui-sass-rails.

eprothro avatar eprothro commented on September 10, 2024

That is better and would have fixed my case, yes.

I assumed that unless we explicitly know a future version breaks something, that >= is the best practice. However, @jhilden you know more about what the potential risks are here than I do, so I defer.

@mattsjohnston can you provide more specifics about your conflict?

from jquery-ui-sass-rails.

EntilZha avatar EntilZha commented on September 10, 2024

I am getting this error since jquery-ui-rails is on 4.1 and this package is on 4.0.2. Is there an easy fix?

from jquery-ui-sass-rails.

jhilden avatar jhilden commented on September 10, 2024

This gem will need to be updated. I can work on it as soon as I have some time, but any help/PR in the meantime would be highly appreciated.

from jquery-ui-sass-rails.

cantonyselim avatar cantonyselim commented on September 10, 2024

Have there been any updates on this? I am having trouble installing ActiveAdmin

from jquery-ui-sass-rails.

stephenjlovell avatar stephenjlovell commented on September 10, 2024

Am also still seeing this issue with rails_admin (>= 0)

from jquery-ui-sass-rails.

jhilden avatar jhilden commented on September 10, 2024

I'm sorry, but I'm not actively maintaining this gem anymore. But PRs and potential new maintainers are very welcome.

from jquery-ui-sass-rails.

cantonyselim avatar cantonyselim commented on September 10, 2024

@stephenjlovell I can't help you with rails admin but I played with the gem spec on both this gem and activeadmin and got them to play nice. If you are interested check out the forks here

from jquery-ui-sass-rails.

jhilden avatar jhilden commented on September 10, 2024

As I said, PRs are always welcome.

from jquery-ui-sass-rails.

stephenjlovell avatar stephenjlovell commented on September 10, 2024

@cantonyselim thanks for the link, will check it out. I'm building a survey automation app and experimenting with a few options for the back end.

from jquery-ui-sass-rails.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.