Comments (6)
OK, I see what is going on.
In order to avoid expensive re-renders in disambiguation, I operate with a DisambData structure that just contains names and dates. This works fine for author-date styles, but not so well when titles are rendered as part of the citation, as in this case. We may need to do an additional render at the last step to avoid this problem.
from citeproc.
What should the result be (and why)? (If you can explain this you can save me the trouble of combing through the linked thread.)
from citeproc.
Sure.
The expected result for the notes is:
- Doe, A First Book by John Doe.
- Doe, A Second Book by John Doe.
- Smith, A First Book by Jane Smith.
The additional year in the Doe citations is not correct. I guess the date is inserted by this macro which is called on line 1353:
<macro name="date-disambiguate">
<choose>
<if disambiguate="true" type="personal_communication" match="any">
<text macro="issued"/>
</if>
</choose>
</macro>
Now, the spec says about disambiguate="true"
:
When set to “true” (the only allowed value), the element content is only rendered if it disambiguates two otherwise identical citations. This attempt at disambiguation is only made when all other disambiguation methods have failed to uniquely identify the target source.
But in this case, there is clearly no need to disambiguate these citations by adding the date.
from citeproc.
Is this rule even getting triggered here? This is not a personal_communication
but a book
.
from citeproc.
Oh, sorry, I guess the match=any matches if EITHER condition is met.
This is definitely getting triggered, because the output changes if I remove it.
from citeproc.
Or maybe re-render at every step and measure the performance impact.
from citeproc.
Related Issues (20)
- disambiguation error (note style)
- Detection of English-language entries only permits ISO 639-1 codes HOT 2
- Reference stripped from the output in cites with position "ibid" and a suffix without a locator HOT 7
- How could citeproc support CSL-M layout? HOT 40
- `link-bibliography` option does not hyperlink references without URLs in notes HOT 6
- Localizing parts of citations HOT 5
- Error in latex generation of portuguese quotes in CSLReferences field HOT 15
- Installing the executable HOT 2
- [Help] Author only citations BibTex HOT 1
- Incorrect sorting of bibliography HOT 12
- Stopword capitalized after abbreviation HOT 6
- Use citeproc for style development HOT 11
- Support for link/color only the year in the citations HOT 1
- Can I replace the citation key with bibliography? HOT 3
- Author-in-text citations render as superscript HOT 3
- Add support for semantic markup in bibliographies HOT 3
- Disambiguation error HOT 4
- `Undefined Control Sequence \citeproctext` in custom pandoc template HOT 2
- Short DOI prefix in citations HOT 11
- Custom Field in CSLJson silently dropped HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from citeproc.