Comments (5)
@bpbond OMG THIS EXPLAINS SO MUCH. It never made sense to me that Hector was regrowing more carbon than it lost in my pulse experiments, because that isn't how returning to equilibrium should work. But this totally explains it!! So glad you figured it out and fixed it!
from hector.
Also, that is SO satisfying to see vegetation just drop to a new equilibrium.
from hector.
New behavior
In b6cf6cb we change things so that LUC, FFI, and DACCS are retrieved from their respective time series only once, at the beginning of the timestep in slowparameval()
. These private values — current_luc_e
, current_luc_u
, etc. — are then referenced throughout calcderivs()
and stashCValues()
.
Fri Oct 28 03:53:53 2022:NOTICE:run: 1799
Fri Oct 28 03:53:53 2022:NOTICE:run: 1800
Fri Oct 28 03:53:53 2022:NOTICE:run: 1801
-----------------------
1801 yf = 1
luc_e = 10
veg_c = 558.996 Pg C
global luc_fva_biome_flux = 2.11675 Pg C
global veg_c = 556.879 Pg C after luc
Fri Oct 28 03:53:53 2022:NOTICE:run: 1802
Fri Oct 28 03:53:53 2022:NOTICE:run: 1803
Fri Oct 28 03:53:53 2022:NOTICE:run: 1804
This also reduces the code size, which is a nice bonus.
from hector.
from hector.
I am so enamored of this LUC pulse test — it's a stringent test of model behavior — that adding it as a permanent test.
from hector.
Related Issues (20)
- Memory leak / other memory issues HOT 2
- Consolidate GA files? HOT 3
- DOECLIM variables & time series HOT 5
- Documentation v3 push HOT 5
- Input parameters in a centralized CSV HOT 4
- Zeroes getting returned from fetchvars HOT 4
- Build V3 Documentation
- Atmospheric CO2 returning high values HOT 5
- unitval::unitsName() needs unit testing
- Remove cout calls from ocean_csys - lines 162-177 HOT 4
- Two-pool soil model
- multiple-biomes.Rmd fails HOT 2
- Add to Hector publications
- Hector crashing with various NBP constraints HOT 1
- Pre-commit hook or test for C++ code formatting? HOT 2
- NPP reduction from LUC fluxes, again
- clang-format shouldn't touch rcpp files!
- Automate the input_params and output tables HOT 1
- Increasing CO2 under 0 NBP constraint HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hector.