Giter Club home page Giter Club logo

Comments (6)

rplzzz avatar rplzzz commented on May 26, 2024

@calebbraun Was this fixed in #27? If so, then we can close this issue. If not, then we'll leave it open to remind us to circle back to it when we're less busy.

from gcammaptools.

calebbraun avatar calebbraun commented on May 26, 2024

There are now simplified versions of the map data, however GCAM-USA is still missing (although I have a shapefile that can be used for it, but it needs to be simplified and have non-US states removed). GCAM-China also should be revisited because the simplified map does not look good with the China extent, and the non-simplified one still has too much detail.

from gcammaptools.

rplzzz avatar rplzzz commented on May 26, 2024

Ok, we'll leave this open to remind us.

from gcammaptools.

crvernon avatar crvernon commented on May 26, 2024

@calebbraun @rplzzz We can remove the non-us states/provinces from the shapefile I sent you easily. I will dissolve these tomorrow and send them to you. As for GCAM-China, we can reduce the degree to which we simplify the original and perhaps apply a smoothing algorithm that will maintain the correct topology (no sliver polygons, etc.). Point me to the GCAM-China file and I will take a look at this tomorrow as well.

from gcammaptools.

calebbraun avatar calebbraun commented on May 26, 2024

@crvernon The GCAM-China file being used is in inst/extdata/rgnchn/GCAM_China.geojson

from gcammaptools.

calebbraun avatar calebbraun commented on May 26, 2024

Those two pull requests add GCAM-USA map data, simplifies the GCAM-China map polygons, and removes the GCAM-China map that was oversimplified.

Examples for each of these maps still need to be added to the vignettes, but I have opened a separate issue for that (#35), so this one can be closed.

from gcammaptools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.