menu-button style not exists for light and dark styles. about jfxtras-styles HOT 12 CLOSED

Hi @MairwunNx

Looks great.

Suggestions:

• Can you shorten the padding between the button text and the arrow?
• Shorten the padding on the left of the text so that the text is closer to the left edge of the button. Also so that the padding to the right of the arrow is the same as the padding to the left of the text.

If you don't understand what I mean I can try clarify things better.

Thank you very much. 👍

from jfxtras-styles.

Hi @dukke , i fully understand you, you right, text align not cool and arrow too.

I think it edits better, see please :)

edit1: on bottom screen a little more padding, if you like better bottom, then i stay on variant bottom :), i think bottom - better 👍

from jfxtras-styles.

Good job 👍

I personally feel the top one is better.
We also need to be careful about the amount of size buttons and other controls have per default. We don't want them to be too big in a desktop app.
Bigger means less things can fit on the screen and in a desktop, productivity app that's usually not very good.

On the other side on a mobile/tablet app we need controls to be big enough to be easily touched with the fingers. Since JavaFX target is mainly desktop apps we can stick with controls that are not too big.

from jfxtras-styles.

@dukke thanks! Button size like on bottom screen i set self, and other man can it do :D, because needed adaptation for sizes, on bottom screen i show with resized buttons, user self choose menu button size :))

If you like it, i can do PR with it changes. 👍

from jfxtras-styles.

Sorry, can you say that again, didn't understand what you mean.

from jfxtras-styles.

@dukke i mean what user can self set button sizes, and need adaptation, because i and make bottom screenshot with demo on another button sizes.

from jfxtras-styles.

I think the top one is better, personally.

You can have a look at DropDownButton in Fluent Design.

Thanks

from jfxtras-styles.

@dukke I know what you like as on top, OK, I stay on top variant, when you have more time, type me and I do PR.

from jfxtras-styles.

Yes please, that would be awesome!

Thanks for your contributions. You've been doing a great job 👍

from jfxtras-styles.

I'm sorry I haven't had time to answer more quickly, your PRs, hopefully I will have time during this weekend.

from jfxtras-styles.

thanks, JMetro good lib, and i it use, because i want to do JMetro better. 👍

resolved in #44

Left: date-time-picker fixes and dialogs.

from jfxtras-styles.

This has been added. Thanks Pavel (@MairwunNx )

from jfxtras-styles.