Add support for TreeTableView about jfxtras-styles HOT 14 CLOSED

@hwaite style for TreeTableView be created soon.

from jfxtras-styles.

Like @MairwunNx said this is still not yet implemented but is in future plans.

from jfxtras-styles.

@hwaite @dukke it good looks? Sorry, tree-table-view styles hard to understand, on currenlty work stage i have

from jfxtras-styles.

Looking good.

Can you have them more inline with the current Table style?

from jfxtras-styles.

@dukke i not looks on Table, if you can, drop here screenshot of table or demo :), thanks.

upd: already finded on your site.

upd2: yes, i try it realize and drop here result.

from jfxtras-styles.

https://pixelduke.com/java-javafx-theme-jmetro/#Table_View

Main thing is, I think, they should both look similar.
We could even change the current table view if we find a way to make it look better and then also have the tree table view look similar to that.

Thanks Pavel

from jfxtras-styles.

I done work, i think it good result, please review it and if like it i do PR. @dukke @hwaite

p.s bug with arrow in row, fixed. gifs recorded before fix.
p.s.s I did not do #111111 for a dark theme, because it is ugly and ugly, too sharp text and high contrast, so I took a softer and darker color.
p.s.s.s i also think what table-view needed to change hover colors like make it i in dark theme in tree-table-view. :)

Thanks for attention 👍

from jfxtras-styles.

It does look good. Well done!

What color did you use for the dark theme? And where are you using that color that's different from #111111? I think we need to use a consistent color throughout all controls.

Some suggestions:

• Left align header text so it aligns with content text?
• Use the same arrow that's used in Table View to indicate that the column is sorted
• Replace blue vertical line with a line with a neutral color (black/white/gray) when dragging columns around
• Light theme: Use gray on row hover like you are using in the dark theme. But try with a lighter gray.
• Light theme: try a lighter accent color for selected row by using the derive css function.
• In the dark theme: use a darker accent color with the derive css function for the selected row.
• dark theme: try with a darker gray for row mouse hover
• remove mouse hover change of color on rows that have no data

I think you can already do the PR if you want.

Thanks!

from jfxtras-styles.

• Left align header text so it aligns with content text?
• Use the same arrow that's used in Table View to indicate that the column is sorted
• Replace blue vertical line with a line with a neutral color (black/white/gray) when dragging columns around
• Light theme: Use gray on row hover like you are using in the dark theme. But try with a lighter gray.
• Light theme: try a lighter accent color for selected row by using the derive css function.
• In the dark theme: use a darker accent color with the derive css function for the selected row.
• Dark theme: try with a darker gray for row mouse hover
• Remove mouse hover change of color on rows that have no data

Done! If you like it, then i do PR, I did everything I could, and I do your instructions as much as possible :)
See changes @hwaite @dukke

p.s i think just accent color, without derive on light and dark theme be better, but if you like better with derive, then i stay on variant with derive. 👍

What color did you use for the dark theme? And where are you using that color that's different from #111111? I think we need to use a consistent color throughout all controls.

• table background dark theme color is #333333, i understand what you want to colors-undiff, but i not can make #111111 it so ugly for eyes and not cool, you can make it, but it be not good, i do not think that this can be critical, because beauty is more important than unification.

from jfxtras-styles.

Good job Pavel, I think it looks really good! Especially the dark theme.

You might be right about the #333333 color, I don't know. I think it's a question of seeing the table view style along with other JMetro controls in a real app and see if it looks good.

Yes, please do a PR.

from jfxtras-styles.

About deriving the accent color and following my suggestions on that: when you do the PR maybe I'll try the derive and we can analyse it further and see if we like it better.
I do feel that perhaps lighter accent color for light theme and darker accent color for dark theme might be better but it's a question of actually experimenting and seeing how it looks.

Thanks 👍

from jfxtras-styles.

@dukke ok! :), thanks, i do PR, i understand you. 👍

from jfxtras-styles.

resolved in #37

from jfxtras-styles.

Closing this issue as this is now available.

from jfxtras-styles.