Date-picker not correct text color on lost focus. about jfxtras-styles HOT 21 CLOSED

Yes that's right.

I still think the gray color makes it feel somewhat like the button is disabled.

from jfxtras-styles.

Thanks, good issue

from jfxtras-styles.

@dukke no problem!

from jfxtras-styles.

@dukke new bugs with date-picker:

Focus traversable button need to disable, because after pressing and lost hover, causes not great effect.

And it :D

from jfxtras-styles.

Ok thanks for reporting that.

Could you please, possibly, file another issue for that bug?

Regarding the issue itself I'm not quite understanding what's it about.

from jfxtras-styles.

@dukke hi! I fixed not cool bug with large menu, but: it was intended what not editable date-picker more than editable? (2 row it - not editable, 1 - editable, 3 - text fields)

from jfxtras-styles.

Hmm. I still don't understand the issue, sorry.

from jfxtras-styles.

@dukke i fixed issue with wrong font size in context-menu for date-picker - understand?)

bug what need to fix:

fix wrong dark theme for date-picker

fix wrong size for date-picker with disabled editable prop

fix wrong font size in context menu in date-picker

fix wrong color selecting today day and selected new day

fix wrong colors of selecting days and day cells

currently i try fix all problems with date-picker.

from jfxtras-styles.

Oh yes, I see it now. Wrong text size of Date-Picker context menu. Nice 👍

from jfxtras-styles.

fixed different height when disabled editable prop.

from jfxtras-styles.

What's this last issue you mention?

from jfxtras-styles.

@dukke
fix wrong size for date-picker with disabled editable prop.
#34 (comment)

What's this last issue you mention?

from jfxtras-styles.

is that last issue the wrong font size of the context menu of Date Picker?

from jfxtras-styles.

@dukke not, wrong font size already fixed, i mean wrong size when disabled editable property :)

from jfxtras-styles.

Sorry... still not sure. Maybe if you tell me the steps to reproduce?

from jfxtras-styles.

I already done and fix dark theme for date-picker, i think it fully done.

Before:

After:

from jfxtras-styles.

👍
Make the calendar icon color also white when the DatePicker is not focused.

from jfxtras-styles.

@dukke I can't do that, this is a direct violation of UX, the user will think that he is focused on the element, when he is not focused on it, if you want, I can do it, but this is not correct

It will also be too contrasted, and then the dark theme may become worse light due to the high contrast and sharpness.

from jfxtras-styles.

Resolved in #45

from jfxtras-styles.

The Fluent Design implementation of the Date Picker with a dark style has the Calendar icon white when the calendar is not focused.

If it is gray I think it is not totally obvious that you can interact with the calendar icon button.

from jfxtras-styles.

In fluent design it make as button with icon :), we have as text-field and combobox :)

needed gray because text-field can be focus-able, bbut if you need write, you can edit color before merging branch

from jfxtras-styles.