Add Accordion styles based on TitledPane style about jfxtras-styles HOT 21 CLOSED

@MairwunNx Sent you an email with some instructions. Cheers 👍

from jfxtras-styles.

@MairwunNx Sorry for the delay in fixing this issue. These days have been though, work wise.
I'll push a fix tomorrow for sure.

Thanks.

from jfxtras-styles.

Good issue, i can you help with it? Or only review your changes? :)

from jfxtras-styles.

Sure thing.

Would you consider submitting PR. Do you want a few pointers on how to do it?

from jfxtras-styles.

@dukke I do not know how to do PR. Yes :)

from jfxtras-styles.

@dukke Thanks bro! I see you instructions, if i do changes with accordion, i make pull request .)))

from jfxtras-styles.

Ahaha, TitledPane style == Accordion style, bro, accordion already done :DD

But, one minus, bottom border real bad, i think you can it fix easy, as i'm :D

from jfxtras-styles.

I think, you need just fix bottom border and close it issue, also thanks for PR instructions on future :)
If i want to change colors \ components - i create PR. 👍

from jfxtras-styles.

from jfxtras-styles.

@dukke no problem :) 👍

from jfxtras-styles.

@dukke Hi! How are you? Have you fixed border? :D

from jfxtras-styles.

Good @MairwunNx , thanks!

Sorry too much work (on my paid job) 😞

Will try to add today.

from jfxtras-styles.

@dukke Good, no problem :)) Goodluck with fixing bottom border of accordion 👍

from jfxtras-styles.

Hi Pavel,

Worked a bit more on it today but I still haven't figured out why the last Titled Pane is being cut at the bottom...

from jfxtras-styles.

@dukke hi, i think i know what caused bottom not correct border, i need style, you already commit changes with pane?

from jfxtras-styles.

The Titled Pane was already commited a few weeks ago.

I've fixed it. Only want to fix one more detail that has appeared: "the disabled border of the content of TitledPane isn't being the same as the border color of the Titled Pane header.
Hopefully I'll still have time today to make this small fix.

from jfxtras-styles.

You can see my changes, scroll up, and see as i make it :), maybe it help you.

from jfxtras-styles.

This has been fixed and pushed. 👍

from jfxtras-styles.

Good Job @dukke ! 👍

What next tasks?

from jfxtras-styles.

Thanks @MairwunNx !

I haven't really look into that but there are a few things I'd like to do:

• TreeTableView styles
• SplitPane?
• Dialogs?
• Accent color constants for easily changing to a nice accent color

from jfxtras-styles.

@dukke Hi! Thanks for // todo, i try make what i can realize, i also try to realize dialogs with supporting dark and light theme, and others your controls. 👍

from jfxtras-styles.