Please, update button dark n light themes to fluent specifications. about jfxtras-styles HOT 8 CLOSED

Thanks for the reference to the theme editor. I already knew it but I haven't had time to explore it in greater detail.
I have even thought of having something like that for JMetro.. not sure...

With time, JMetro will probably have more and easier theming features.

Good Luck! :) I tried to do for your styles, all that was in my power

You did well to create this issue. There is the problem with the border color in the dark theme that I have to fix.
Your issues (and also the suggestions you put in them) definitely help in improving JMetro. Keep it up 👍 😄

from jfxtras-styles.

Fixed by the referenced commit.

from jfxtras-styles.

Hey there Pavel!

1. As for borders:
   You're right. JMetro border color is not right.
   This seems to be a regression as it used to look as you say. See: https://www.pixelduke.com/2018/08/27/fluent-design-button-toggle-button-tooltip/
   We need to account for the accent color, so the border needs to be derived from it or if the user changes accent color things will not work right. See: https://www.pixelduke.com/2018/12/04/jmetro-version-5-released/#more-2418 "Styling JMetro" topic.
   So I think, hard-coding the border color to a specific value won't be the best solution.

I can just take a look at the previous code that worked and replace the new one with the old. If you think that look for the border color in the blog post (first link I referenced) is right.

2. As for pressed state:
   I don't remember where I saw the FD specification for buttons in default state. Can you tell me where to look for this so I can re-check it against your proposed solution.

Thanks Pavel 👍

from jfxtras-styles.

Hello @dukke!

As for borders

Not, button no support changing border colors from accent color! You can simple add transparent for border color of accent color, but it be not true.

Default button

Default button does not exist in Fluent Design specification, but exist in controls and available to use in applications based on UWP. You can remove default button, but it not be redundant element. Default button has style as toggle button in toggled state.

For borders again

You also can make borders color like a button border on hover. If you want save compatibility with theme coloring.

For light theme hover border: #737373, for dark theme hover border color: #676767.

from jfxtras-styles.

Hey Pavel!

Default Button:

• Ah yes, I've probably based myself on the ToggleButton color on fluent design for the color of the javafx Button when it is the default.

Borders:

• If you change the accent color of windows to say green, then run XAML Controls Gallery you'll see that the toggle button is green. The border color will also change to a dark green when mouse hover.
  That's what I wanted to have in JavaFX Button when it is set to default. That's why the border color is a function of the accent_color and should be something like this for the light theme:
  -fx-border-color: derive(ACCENT_COLOR, -40%);
  (The percentage isn't this value right now because I made a mistake, probably when I did the big refactor and messed up this code)

So a programmer can easily change the accent color of JMetro by changing the accent_color variable value and all controls will adjust automatically. They'll also calculate, automatically, variations of the accent color for things like this border we're talking about.

Thanks, regards,

from jfxtras-styles.

Hi @dukke , ok, thanks for attention. :) Fluent XAML theme editor, it can you help with theming.

I understand you. Also I advise to install

Good Luck! :) I tried to do for your styles, all that was in my power

from jfxtras-styles.

Thanks! ))) I'm glad what i can help it issue :) 👍

from jfxtras-styles.

Good Job!

from jfxtras-styles.