Comments (6)
@dukke ! Please review the issue!
from jfxtras-styles.
Sorry my daily paied job has been keeping me ocupied and with no spare time for my open source projects. Is is now fixed.
from jfxtras-styles.
No problem @dukke , i think what you don't work gihub notifications, and i do mention on you. :)) I'm glad what you accepted changes.
from jfxtras-styles.
I knew I wasn't following Fluent Design. I did it because I didn't like the hard transition when the control gets focused.
I do tend to agree with you that this looks better with your suggestion. So I changed the code. Thanks.
I did some changes to your suggestion:
- text_color variable is now the color of text when the text isn't focused
- text_focused_color variable is the text color when the control is focused
- Changed the style of text inputs by overrriding the two vars above. This way all the style is defined by overriding color vars defined in JMetroBase.css
- Changed your black color (#000) to #111. We don't want to use pure black colors.
Just one thing I'd like to add: We're not trying to be an exact copy of Fluent Design (JMetro is inspired by FD and not a direct copy) and whenever we see the chance of improving on FD, we'll do it.
Finally, thanks for this issue report. I like the high level of detail you put into your issue reports and it helps greatly.
Thanks Pavel 👍
from jfxtras-styles.
No problem! :)), i clone your 🥇 styles and test, i understand you. 👍
You also can check my project based on your styles, i think what it looks good :)
https://github.com/MairwunNx/SacredMagician
from jfxtras-styles.
Good, with #111 looks better! :)
from jfxtras-styles.
Related Issues (20)
- FlatAlert style not being applied HOT 1
- Button, ToggleButton - Button does not show border on hover when it is focused HOT 1
- Maven Central Repository Does Not Install Correctly HOT 2
- TextField - TextField with "glitched" background when disabled and inside Dialog
- TextFields - Non-Editable TextFields shouldn't have a 'clear' button HOT 2
- Exception "Failed to load skin 'impl.jfxtras.labs.internal.scene.control.skin.ListSpinnerCaspianSkin'" HOT 2
- JMetro NPE when getOverridingStylesheets().add(source). Should throw instructive exception HOT 2
- JMetro: NoSuchMethodError with no code written HOT 16
- DatePicker - changes height when focused HOT 2
- Spurious classifier tags in dependencies in pom.xml HOT 3
- Style a WebView Web Page using JMetro Theme Style HOT 1
- JMetro: JavaFX 16 JDK17 NullPointerException HOT 3
- Some suggestions of Jmetro on Windows 11 HOT 1
- TreeView, TableView, ListView, TreeTableView - not sure if we need styles for pressed:selected and pressed
- New windows ui (winui3) implement HOT 1
- ProgressBar - Switching from indeterminate, to real and finally back to indeterminate doesn't animate
- Charts lose tick label color after applying jmetro HOT 6
- Scrollpane shrink contents when focused
- Wrong Spinner text color inside TabPane HOT 5
- JFXCentral Badge
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jfxtras-styles.