Giter Club home page Giter Club logo

Comments (6)

MairwunNx avatar MairwunNx commented on July 18, 2024

@dukke ! Please review the issue!

from jfxtras-styles.

dukke avatar dukke commented on July 18, 2024

Sorry my daily paied job has been keeping me ocupied and with no spare time for my open source projects. Is is now fixed.

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on July 18, 2024

No problem @dukke , i think what you don't work gihub notifications, and i do mention on you. :)) I'm glad what you accepted changes.

from jfxtras-styles.

dukke avatar dukke commented on July 18, 2024

I knew I wasn't following Fluent Design. I did it because I didn't like the hard transition when the control gets focused.
I do tend to agree with you that this looks better with your suggestion. So I changed the code. Thanks.
I did some changes to your suggestion:

  • text_color variable is now the color of text when the text isn't focused
  • text_focused_color variable is the text color when the control is focused
  • Changed the style of text inputs by overrriding the two vars above. This way all the style is defined by overriding color vars defined in JMetroBase.css
  • Changed your black color (#000) to #111. We don't want to use pure black colors.

Just one thing I'd like to add: We're not trying to be an exact copy of Fluent Design (JMetro is inspired by FD and not a direct copy) and whenever we see the chance of improving on FD, we'll do it.

Finally, thanks for this issue report. I like the high level of detail you put into your issue reports and it helps greatly.
Thanks Pavel 👍

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on July 18, 2024

No problem! :)), i clone your 🥇 styles and test, i understand you. 👍

You also can check my project based on your styles, i think what it looks good :)
https://github.com/MairwunNx/SacredMagician

from jfxtras-styles.

MairwunNx avatar MairwunNx commented on July 18, 2024

Good, with #111 looks better! :)

from jfxtras-styles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.