Giter Club home page Giter Club logo

Comments (7)

sverdlov93 avatar sverdlov93 commented on August 15, 2024

Hi @leowangms,
Setup JFrog CLI 2.4.0 is released and includes the above feature.
We'd appreciate your feedback on that.

from setup-jfrog-cli.

leowangms avatar leowangms commented on August 15, 2024

Using access token didn't work due to multiple base64 encoding.

in this PR #76 below, accessToken given out by AF is already based64 encoded. Adding a check using isBase64 from 'is-base64' will be much better.

else if (serverObj.accessToken) {
            return 'Bearer ' + Buffer.from(serverObj.accessToken).toString('base64');
}

from setup-jfrog-cli.

leowangms avatar leowangms commented on August 15, 2024

@sverdlov93 - can you fix this with a new release pls?

from setup-jfrog-cli.

sverdlov93 avatar sverdlov93 commented on August 15, 2024

@leowangms, thanks for reporting this issue.
This PR should fix it.
I will update this thread once the next release will be out.

from setup-jfrog-cli.

sverdlov93 avatar sverdlov93 commented on August 15, 2024

Hi @leowangms,
Setup JFrog CLI 2.4.1 is released and should fix the above issue.

from setup-jfrog-cli.

leowangms avatar leowangms commented on August 15, 2024

Thanks. This version works.

from setup-jfrog-cli.

davereid-pfg avatar davereid-pfg commented on August 15, 2024

Yup, works for my use case as well.

from setup-jfrog-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.