Giter Club home page Giter Club logo

Comments (44)

daniellizik avatar daniellizik commented on May 18, 2024 8

On osx vscode integrated terminal 0 is nearly indistinguishable from 8

Screen Shot 2020-01-16 at 16 46 46

getting rid of the slash or dot from 0 entirely would help 🤷‍♂

from jetbrainsmono.

sharpjs avatar sharpjs commented on May 18, 2024 8

I've made available JetBrains Mono Slashed, which is JetBrains Mono with slashed zero as the default. I am using the font myself, so I will try to keep it relatively up-to-date with the official font.

from jetbrainsmono.

djoerg avatar djoerg commented on May 18, 2024 6

It seems to me, that the need to distinguish the 'O' from zero is a relict from the past where all IDEs and Text Editors had only a single color.

Consider this:

  • almost all IDEs/TextEditors these days colorize numbers and characters differently
  • how often do you have an 'O' next to a zero and how often a '8' next to a zero?

For me, that are two very good reasons to not decorate the zero with anything that makes it harder to distinguish from an '8'!

@NetOperatorWibby May i kindly ask you to invest the time to make a version without any decoration on the zero? (Maybe just copy the 'O'). I would highly appreciate it, and i think many others too.

Edit:
@NetOperatorWibby You can ignore my 'request'!. Found your script in the Sudo-Repo to replace characters and it worked! (thanks for that) Now my zero is an 'O' 😃

from jetbrainsmono.

qgates avatar qgates commented on May 18, 2024 4

@philippnurullin I'd like this option too, but I can't see how in sublime text. ST 3.2 supports some ssXX stylistic sets (where XX <= 10) but not the 'zero' mod. Also it'd be nice to have a variant of the font pack with slashed zeros for users of older software / terminals etc..

Vscode can use the modified zero however, just change editor.fontLigatures setting (JSON settings):

"editor.fontLigatures": "'zero'",

ps. Are the stylistic set variations for JBM documented anywhere?

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024 4

@k0pernikus Unfortunately not yet. You can follow this issue on YouTrack https://youtrack.jetbrains.com/issue/IDEA-221886

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024 4

@qgates Wow, sorry. Totally missed your message.

There is not much beside the slashed zero feature now.

Making a lot of different font family's is not a good solution. For example, is we will make the version of JetBrains Mono without ligatures in 4 weights with italics, 8 total + version with ligatures, 8 files. Then each of this version will have the dotted zero & slashed. Thats leaves us with 32 font files. At some point (soon) we will be expanding the weights from 4 to 7, its 56 files. Yes, it can be automated, but complexity of system will only grow & create an opportunity for an error. The only way i see it can be done good, is adopting the approach of Input Mono with the visual font family settings. This will be a good "next" step, right now we are more concentrated on present.

from jetbrainsmono.

sewkokot avatar sewkokot commented on May 18, 2024 3

Yes, it would be good to be able to download the font pack with slashed zero as default. Emacs don't support stylistic sets either. The dotted zero is somewhat unpredictable, sometimes the dot is centered and in other font sizes is not. For me JBM font wins ahead of Consolas (my so far winner), Hack, Fira Code, Fantasque Sans Mono and Input Mono. Thank you :)

from jetbrainsmono.

alexeyten avatar alexeyten commented on May 18, 2024 3

@KillyMXI

"editor.fontLigatures": "'calt' 0, 'zero' 1"
// or "'calt' off, 'zero' on"

image

from jetbrainsmono.

astrolemonade avatar astrolemonade commented on May 18, 2024 3

Ok, so I swapped the dotted zero with slashed zero(and also added slashed zero to the NL versions)
JetBrains-Mono_Zero.zip
Note 1: I did not renamed the actual name font !!! In order for it to work you have to remove the JetBrains Mono family before installing the patched one!
Note 2: Let me know if it's ok to you that I shared the modified fonts here
Let me know if the patch worked for you

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024 3

@cata0309 I'm 100% ok with this. Tat's why the project is open source.

from jetbrainsmono.

elshize avatar elshize commented on May 18, 2024 3

For posterity and search indexer: in kitty terminal, here's what you do:

font_features JetBrainsMono-Light +zero

More info in docs

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024 1

@daniellizik There is no slash currently, it's a dot. Also, I think increasing your text size would help discern the difference.

The reason why the zero has anything in it to begin with is to better distinguish from "O". Monospaced "O" looks awfully similar to "0" at a glance.

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024 1

@cata0309 Glad to hear you found a solution.

from jetbrainsmono.

k0pernikus avatar k0pernikus commented on May 18, 2024 1

@cata0309 Can you please provide your patched font file?

from jetbrainsmono.

Ypnose avatar Ypnose commented on May 18, 2024 1

Thanks for your work @sharpjs !
It is much better, especially for people subject to astigmatism. As you renamed the font we can also have two variants.

from jetbrainsmono.

szeiger avatar szeiger commented on May 18, 2024 1

To add a data point: This is in the latest IntelliJ on Windows 10, 15 points on a screen with 125% dpi scaling. 0 and 8 are almost indistinguishable (which IMHO is far worse than 0 and O):
Screenshot 2021-11-11 181719

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024

There is a slashed zero in JetBrains Mono. But to use it, your IDE needs to support stylistic sets (opentype feature).

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

@philippnurullin Thanks for the tip! Sublime Text apparently doesn't have support for specifying a slashed zero in its settings. Still.

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

If your IDE doesn't support the ligatures necessary for slashed zeroes, this patch should work. I used FontLab to replace the default zero with the slashed variant. In FontBook (macOS) you won't see it in the preview but it'll appear in your IDE.

from jetbrainsmono.

k0pernikus avatar k0pernikus commented on May 18, 2024

@philippnurullin Do JetBrains IDE support "support stylistic sets (opentype feature)", and if so, how do I enable this?

from jetbrainsmono.

qgates avatar qgates commented on May 18, 2024

@sewkokot Agree with all your points. FWIW I created a separate issue #104 about dotted 0 being off-center at different font sizes.

from jetbrainsmono.

qgates avatar qgates commented on May 18, 2024

@philippnurullin Hey, no apology necessary 🙂

I agree that having multiple fonts for different tastes could easily get out of hand and I also like how Input Mono has solved that problem. This would be great for the future, and might allow for a bunch of variations including the $ discussed elsewhere, zero and also {} which I think could look slightly nicer in JBM (don't worry, not going to create an issue about this!).

Oh and while on the nitpick there's something about the 5 that looks slightly wrong as well. Think the bottom loop is slightly overcome by the square top. Fira has that one perfect 😉

from jetbrainsmono.

kovica avatar kovica commented on May 18, 2024

@djoerg No, we won't.

Don't you guys mess with my 0s and Os. :)

from jetbrainsmono.

KillyMXI avatar KillyMXI commented on May 18, 2024

Interesting. How in the world I'm supposed to learn that this font has a stylistic set (OpenType alternative) for zero looks?

It has to be documented somewhere.

But, while I'm happy the issue with the slashed zero is somewhat addressed, it seems like I can't make use of it in VScode. Using the zero feature also means I have to enable ligatures. But I can't stand them before the issue #11 is resolved.

From https://fontdrop.info/ I can see that there are two features - zero and calt. But any combination for the "editor.fontLigatures" value except false leaves all ligatures enabled, while I need all shape-changing garbage disabled.

from jetbrainsmono.

KillyMXI avatar KillyMXI commented on May 18, 2024

@alexeyten thank you! It did the trick.

Now my only complain within this issue is about documentation - better have all available features listed in the readme / at the website.

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024

@KillyMXI Yes, we will add the list of all the features at some point.
Right now there is only this one, so it feels kind stupid to add the whole section with OpenType features list. But i understand why it can be important.

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

@philippnurullin Thanks for the tip! Sublime Text apparently doesn't have support for specifying a slashed zero in its settings. Still.

from jetbrainsmono.

f2l2pe avatar f2l2pe commented on May 18, 2024

@NetOperatorWibby If you prefer shashed zero, set 'zero' stylistic feature to your font. For example, if you're using VS Code, add "editor.fontLigatures": "'zero'" to the settings.json file.

How would i do that in visual studio 2019?

The problem is that most of the tools doesnt support stylistic sets, dotted zeroes are hard to distinguish at small sizes.
The font already has a no ligature version, an slashed zero variant would be nice to have too.
The dotted zero is the only thing that is making me not use jetbrains mono

from jetbrainsmono.

astrolemonade avatar astrolemonade commented on May 18, 2024

@philippnurullin can you provide a version with slashed zero ? I am using Intellij IDEA based IDE's and I can't get around this issue.

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024

@cata0309 Hi. I can't because of the the problems it will bring. More about it here → #8 (comment)
In IDEA behalf you can follow this issue https://youtrack.jetbrains.com/issue/IDEA-221886

from jetbrainsmono.

astrolemonade avatar astrolemonade commented on May 18, 2024

I editted the font in FontForge by switching the zeros, I had no problem using it thought.

from jetbrainsmono.

astrolemonade avatar astrolemonade commented on May 18, 2024

Of course, is it ok if I link it here @philippnurullin ? I am thinking about making an archive.

from jetbrainsmono.

f2l2pe avatar f2l2pe commented on May 18, 2024

@cata0309 loved it ! im already using this version

from jetbrainsmono.

astrolemonade avatar astrolemonade commented on May 18, 2024

I am glad I made someone happy !

from jetbrainsmono.

lostcoda avatar lostcoda commented on May 18, 2024

@cata0309 Thanks for the patched version, but the ligatures seem to have stopped working.

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

@lostcoda I made my own patch a few days after I made this issue and ligatures work.

from jetbrainsmono.

lostcoda avatar lostcoda commented on May 18, 2024

@NetOperatorWibby In Intellij, ligatures work just fine from your patch but slashed zero doesn't. It is still dotted.

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

@lostcoda That's strange, it works in Sublime Text. Did you completely remove the previous font before installing my patched one?

from jetbrainsmono.

lostcoda avatar lostcoda commented on May 18, 2024

@NetOperatorWibby Yes, I did. Everything works fine as it is in vscode, but not in intellij.

from jetbrainsmono.

NetOpWibby avatar NetOpWibby commented on May 18, 2024

@lostcoda Oh damn, idk what to do about that.

from jetbrainsmono.

trygveaa avatar trygveaa commented on May 18, 2024

IntelliJ bundles JetBrains Mono. I guess you have to remove it from the IntelliJ installation in addition to removing it globally.

from jetbrainsmono.

philippnurullin avatar philippnurullin commented on May 18, 2024

@lostcoda You can upgrade to 2020.1 or manually remove the bundled fonts. This guid will give you an idea where to find them #142

from jetbrainsmono.

lostcoda avatar lostcoda commented on May 18, 2024

@trygveaa @philippnurullin Everything's working fine after removing the built-in bundle. Thanks.

from jetbrainsmono.

jasmingrbo avatar jasmingrbo commented on May 18, 2024

@sharpjs
Actually your slashed version renders some characters slightly different than the original version: e, f, J, K, % to name a few.
If you could investigate what's going on and have slashed version rendering identically to the original version.

Thank you and have a good one!

from jetbrainsmono.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.