Giter Club home page Giter Club logo

Comments (9)

sa160690 avatar sa160690 commented on July 19, 2024 1

Hi @likeanowl, can I take this up.

from topias.

svitkovsergey avatar svitkovsergey commented on July 19, 2024

Hi @sa160690 !
Yes, feel free to take this issue! Unfortunately, this project lacks contributing guidelines and documentation yet, but I can answer your questions, if you have any. :)

from topias.

sa160690 avatar sa160690 commented on July 19, 2024

Can you please assign this to me.

from topias.

sa160690 avatar sa160690 commented on July 19, 2024

Do you already have sql scripts for the schema you intend to build?

from topias.

sa160690 avatar sa160690 commented on July 19, 2024

Hi @likeanowl, I have made the changes. Can you suggest a way to test the changes?

from topias.

svitkovsergey avatar svitkovsergey commented on July 19, 2024

Hi @sa160690 !
Currently there is a lot of raw SQL in https://github.com/ml-in-programming/topias/blob/master/src/main/java/db/DatabaseInitialization.java . My main idea when creating this issue was to move all these initialization queries to liquibase patches.
If you have created some changes, please consider opening pull request, so I can review them and merge after.

from topias.

sa160690 avatar sa160690 commented on July 19, 2024

@likeanowl, I have raised a pull request: #15

I still have not been able to test my changes. If possible, if you can guide me on how to test this plugin locally and I will be happy to do it. Thanks.

from topias.

svitkovsergey avatar svitkovsergey commented on July 19, 2024

@sa160690
Your PR looks good to me! Thank you!
To test it, you can run runIde task in gradle and check if anything good. Unfortunately, there is no any test coverage yet (but I plan to add some tests in close future). Therefore I usually test all changes manually.

from topias.

svitkovsergey avatar svitkovsergey commented on July 19, 2024

Resolved in #15

from topias.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.