This is just nitpicky, but it would be nice to get a list of the songs that were not a

hey <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url

Present a list of LovedTracks that were not able to match (in the log or somewhere else). about jellyfin-plugin-lastfm HOT 3 OPEN

jesseward commented on May 22, 2024

Present a list of LovedTracks that were not able to match (in the log or somewhere else).

from jellyfin-plugin-lastfm.

Comments (3)

jesseward commented on May 22, 2024

hey @OdinGitDat, logged this new issue.

The request sounds reasonable, will log a future item here in the event someone wants to pick it up. I suspect there are some songs missed due to the comparison implementation.

jellyfin-plugin-lastfm/Jellyfin.Plugin.Lastfm/Utils/StringHelper.cs

Lines 6 to 24 in 6a29fcd

 public static class StringHelper 

 { 

 public static bool IsLike(string s, string t) 

 { 

 //Placeholder until we have a better way 

 var source = SanitiseString(s); 

 var target = SanitiseString(t); 

 return source.Equals(target, StringComparison.OrdinalIgnoreCase); 

 } 

 private static string SanitiseString(string s) 

 { 

 //This coiuld also be [a-z][0-9] 

 const string pattern = "[\\~#%&*{}/:<>?,-.()|\"-]"; 

 //Remove invalid chars and then all spaces 

 return Regex.Replace(new Regex(pattern).Replace(s, string.Empty), @"\s+", string.Empty); 

 }

There is no distance or fuzzy matching. So if you have a slight difference in naming such as "remix", "live" or "Artist featuring ...", it will not match.

from jellyfin-plugin-lastfm.

blers27 commented on May 22, 2024

To me, this looks like extreme nitpicking whatever the plugin is doing. The plugin retrieved 315 lovedTracks from LastFM and it only matched 5 songs for me. That's a 1.6% match rate :/

from jellyfin-plugin-lastfm.

jesseward commented on May 22, 2024

I have added a known issues section to the README and included this issue . See https://github.com/jesseward/jellyfin-plugin-lastfm#known-issues

from jellyfin-plugin-lastfm.

Recommend Projects

Present a list of LovedTracks that were not able to match (in the log or somewhere else). about jellyfin-plugin-lastfm HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public static class StringHelper
	{
	public static bool IsLike(string s, string t)
	{
	//Placeholder until we have a better way
	var source = SanitiseString(s);
	var target = SanitiseString(t);

	return source.Equals(target, StringComparison.OrdinalIgnoreCase);
	}

	private static string SanitiseString(string s)
	{
	//This coiuld also be [a-z][0-9]
	const string pattern = "[\\~#%&*{}/:<>?,-.()\|\"-]";

	//Remove invalid chars and then all spaces
	return Regex.Replace(new Regex(pattern).Replace(s, string.Empty), @"\s+", string.Empty);
	}