Giter Club home page Giter Club logo

Comments (8)

jesseduffield avatar jesseduffield commented on April 28, 2024 6

@mohamedahmed01 the issue with that code is that I'm using SetPgid so that I can group child processes of a process I run. An example is docker-compose logs which itself spawns one process for each service, all of which print to stdout. I give them all the same process group id so that I can kill the group when I want to show the output of some other command. By just returning nil I'd be losing that functionality.

from that link:

func SetPgid(pid, pgid int) error {
	return nil
}

I believe this is the only real think preventing windows from working, so a proper solution may not be too hard to achieve. Something along the lines of looking at the process table to find all descendants of the process we want to kill could suffice.

from lazydocker.

vitr avatar vitr commented on April 28, 2024 5

Given that it looks like WSL will do the trick, is there anybody with a strong objection against WSL?

Yes) we should have the same Windows binary as we've got for lazygit. I understand if this feature request takes some time, but it will be much appreciated.

from lazydocker.

mohamedahmed01 avatar mohamedahmed01 commented on April 28, 2024 1

@jesseduffield
It seems this code would allow you to bootstrap windows support but i dont know enough go lang enough to implement it , would you check it out.
https://blog.csdn.net/fyxichen/article/details/51857864

from lazydocker.

lcdessantos avatar lcdessantos commented on April 28, 2024 1

I managed to get it working on the Windows 10 (Version 1903) WSL and Docker for Windows. But first I had to do the things instructed in this tutorial (with the exception of the "volume mounts" part): Setting Up Docker for Windows and WSL to Work Flawlessly.

from lazydocker.

jesseduffield avatar jesseduffield commented on April 28, 2024

Would it suffice to run this in WSL? There are some tricky things I would need to fix up to get this to run in windows itself

from lazydocker.

jesseduffield avatar jesseduffield commented on April 28, 2024

Given that it looks like WSL will do the trick, is there anybody with a strong objection against WSL?

from lazydocker.

harvzor avatar harvzor commented on April 28, 2024

Is the idea that we run LazyDocker in WSL, and expose the Docker Desktop (which is running in Windows) daemon?

from lazydocker.

ofek avatar ofek commented on April 28, 2024

Yes, I'd greatly appreciate Windows support as well

from lazydocker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.