Comments (3)
Good catch. Makes sense to validate that there already. I added it for the next release.
from jesse.
Do you get an error? Just tested it and got no error? That's true about the Bitfinex symbol format, but that's all handled by Jesse behind the scenes.
We need the dash because otherwise, Jesse doesn't know which chars count to quote and which to base. Especially with those varying lengths (3 and 4 chars) these days.
from jesse.
Yes, I do get an error:
routes = [
('Bitfinex', 'ETHUSD', '2h', 'Test'),
]
root@4ea38a1669b7:/home/mybot# jesse backtest '2020-01-01' '2021-03-27'
============================== EXCEPTION TRACEBACK:
...
File "/jesse-docker/jesse/helpers.py", line 504, in quote_asset
raise InvalidRoutes("The symbol format is incorrect. Correct example: 'BTC-USDT'. Yours is '{}'".format(symbol))
=========================================================================
Uncaught Exception: InvalidRoutes: The symbol format is incorrect. Correct example: 'BTC-USDT'. Yours is 'ETHUSD'
And for the dash:
# trading routes
routes = [
('Bitfinex', 'ETH-USD', '2h', 'Test'),
]
============================== EXCEPTION TRACEBACK:
....
File "/jesse-docker/jesse/services/required_candles.py", line 73, in load_required_candles
raise CandleNotFoundInDatabase(
=========================================================================
Uncaught Exception: CandleNotFoundInDatabase: No candle for Bitfinex ETH-USD is present in the database. Try importing candles.
Which makes sense, since what I have in the database is ETHUSD
and not ETH-USD
jesse_db=# select distinct symbol from candle;
symbol
----------
ETHUSD
(1 row)
However, I just tried importing candles from Bitfinex specifically for ETH-USD
and it loaded them correctly, but when I did this first time I clearly remember it saying something like ETH-USD
is not found, but ETHUSD
was found and that's what I imported.
Anyways, I think you just need to validate dash presence in symbols when doing a candle import, because it allows us to import dashless symbols which then won't work
root@4ea38a1669b7:/home/mybot# jesse import-candles 'Bitfinex' 'ETHUSD' '2018-01-01'
Importing 1182 days candles from "Bitfinex" for "ETHUSD". Duplicates will be skipped. All good? [Y/n]: Y
Importing candles... [------------------------------------] 0% 00:40:54
from jesse.
Related Issues (20)
- File "jesse_live\exchanges\LiveExchange.py", line 367, in jesse_live.exchanges.LiveExchange.LiveExchange._connect_ws._on_message HOT 15
- Precision Bug HOT 3
- Supporting Multiple Symbols For a Strategy Backtest HOT 1
- download link on the website are broken HOT 1
- install error For countries that do not meet the network conditions HOT 1
- [Live Mode] Session terminated as the result of an uncaught exception HOT 2
- After a position opened using different time window in order to check situation HOT 2
- There is no bitget example HOT 1
- Kraken data HOT 1
- Integrating Forex data from a Oanda API HOT 1
- linux/arm64 docker image HOT 4
- Live-trading plugin cannot be run on ARM platform HOT 1
- fee = config['env']['exchanges'][self.exchange]['fee']. KeyError: None HOT 2
- Add tradingview-webhook HOT 2
- get_cadles for > 1m routes does not work due to some legacy code HOT 1
- when running paper-trade mode, DELETE requests lead to unhandled exception (err 500) HOT 2
- wrong period starts for 45m candles in PAPERTRADE mode HOT 11
- Option Support HOT 2
- circular dependency with python 3.11 HOT 3
- Bug - link not working HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jesse.