LocalStorage and 0.9.10 Collection update about backbone.localstorage HOT 13 CLOSED

I'll need more information.

The new collection smart update? Point me to lines of code, a diff or at least a change log entry.

All tests pass using 0.9.10, so this must be a new feature I'm not aware of. Please explain it :)

from backbone.localstorage.

Sure.

http://backbonejs.org/#Collection-update.

It could be possible that I'm completely misunderstanding the functionality.

from backbone.localstorage.

I do not have access to commit to the repository, but the latest version of Backbone requires the following changes:

     if (options && options.success)
-      if (Backbone.VERSION === "0.9.10") {
-        options.success(model, resp, options);
-      } else {
-        options.success(resp);
-      }
+      options.success(resp);

from backbone.localstorage.

@Krivega Yes, but some people could still be using 0.9.10... going to leave that for a little while.

from backbone.localstorage.

Yes, but if use https://github.com/documentcloud/backbone/blob/master/backbone.js (general change in commit jashkenas/backbone@e4c046c )

from backbone.localstorage.

it would be good for this purpose set a new version of Backbone(0.9.11)

from backbone.localstorage.

@Krivega we don't follow master, we follow the stable releases.

from backbone.localstorage.

With the official reason of 1.0 will there be any plans to support http://backbonejs.org/#Collection-set to sync LocalStorage?

from backbone.localstorage.

@dlcerva Does it require anything different in the sync method? I don't see it right off the bat.

from backbone.localstorage.

Would you mind writing a test for this? I will, but it might take some time before I get around doing it.

Once I have a failing test, the fix should be easy.

from backbone.localstorage.

@jeromegn any progress on this?

from backbone.localstorage.

@jeromegn weighing in that I too am interested in this. Thanks!

In the meantime, I have extended my local storage collection with a save method. My use case is simplified since all of the models are updated and never deleted from the collection.

Backbone.Collection.extend({
  // localStorage, model, etc
  save: function() {
    this.each( function(model) {
      Backbone.localSync("update", model)
    })
  }
})

I just call it manually after set, but listening for add/change/remove events and proxying to save should work for more complicated use cases. You would of course need to add an optional argument which is a model and sync action to alter behavior.

from backbone.localstorage.

you really need tests?

from backbone.localstorage.